Add use_repo_add and use_repo_remove commands #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Wyverald Could you review for the Bzlmod aspects? |
fmeum
force-pushed
the
use_repo
branch
2 times, most recently
from
6c8bede to
7db5b82
Compare
Wyverald
reviewed
Mar 30, 2023
|
This is soft-blocked on #1150 as otherwise the |
These commands can be used to programmatically update `use_repo` calls in MODULE.bazel files. In the future, Bazel will emit buildozer fixups relying on this command when it detects that such calls are out-of-date.
|
@Wyverald I updated the signature and name of the label normalization function and added a reference to https://github.com/bazelbuild/bazel/blob/dd822392db96bb7bccdb673414a20c4b91e3dbc1/src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java#L416. |
|
@vladmos Are you available to review this PR? |
|
Sorry, I was conducting a large scale change because of some incompatible changes of formatting rules and temporarily put all other PRs on hold. LGTM |
vladmos
approved these changes
Apr 12, 2023
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
* Preserve compactness of `use_repo` and `use_extension` calls * Add `use_repo_add` and `use_repo_remove` commands These commands can be used to programmatically update `use_repo` calls in MODULE.bazel files. In the future, Bazel will emit buildozer fixups relying on this command when it detects that such calls are out-of-date. * Adapt label normalization to be closer to upstream * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands can be used to programmatically update
use_repocalls in MODULE.bazel files. In the future, Bazel will emit buildozer fixups relying on this command when it detects that such calls are out-of-date.Fixes #1149
Work towards bazelbuild/bazel#17908