Allow G1 in tools/jdk/BUILD.java_tools. #8964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
approved these changes
Jul 24, 2019
iirina
approved these changes
Jul 24, 2019
|
Thanks! |
|
@benjaminp @meisterT Do you want this change to be in bazel 0.29? It requires doing a java_tools release and updating its version in bazel. I just finished a java_tools release (#8960), but if you think the benefits of this change are worth it, I'll do a patch release before 0.29 is cut. |
|
No, I don't need a release. Thank you for the offering, though. |
bazel-io
pushed a commit
that referenced
this pull request
Oct 1, 2019
*** Reason for rollback *** This change introduced a performance regression in bazel. More details in #9270. *** Original change description *** Allow G1 in tools/jdk/BUILD.java_tools. This is a followup to 01e6e05. (I think BUILD.java_tools was introduced in between the creation of the PR for 01e6e05 and its landing.) Closes #8964. PiperOrigin-RevId: 272156477
iirina
added a commit
to iirina/bazel
that referenced
this pull request
Oct 1, 2019
*** Reason for rollback *** This change introduced a performance regression in bazel. More details in bazelbuild#9270. *** Original change description *** Allow G1 in tools/jdk/BUILD.java_tools. This is a followup to 01e6e05. (I think BUILD.java_tools was introduced in between the creation of the PR for 01e6e05 and its landing.) Closes bazelbuild#8964. PiperOrigin-RevId: 272156477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to 01e6e05. (I think BUILD.java_tools was introduced in between the creation of the PR for 01e6e05 and its landing.)