Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singlejar & ijar builds and add tests. #8950

Closed
wants to merge 1 commit into from
Closed

Fix singlejar & ijar builds and add tests. #8950

wants to merge 1 commit into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Jul 22, 2019

No description provided.

@iirina iirina requested a review from meteorcloudy July 22, 2019 13:36
@iirina
Copy link
Contributor Author

iirina commented Jul 22, 2019

@meteorcloudy I added the tests here and fixed them for the other platforms.

@iirina iirina added the team-Rules-Java Issues for Java rules label Jul 22, 2019
@meteorcloudy
Copy link
Member

Oh, nice! The tests are also passing on Windows. Does this mean if we build the toolchain again, it will work for RBE on Windows?

meteorcloudy
meteorcloudy approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@iirina
Copy link
Contributor Author

iirina commented Jul 22, 2019

The tests are disabled on Windows right now:

 if "$is_windows"; then
    echo "Skipping test on Windows." && return
 fi

I'll submit this and you can rebase your PR afterwards.

@meteorcloudy
Copy link
Member

Ah... I see. Thanks!

@meteorcloudy meteorcloudy mentioned this pull request Jul 22, 2019
Closed
@bazel-io bazel-io closed this in f5a6ee1 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iirina @meteorcloudy @googlebot