NDK 19 and 20 support #8524
Closed
NDK 19 and 20 support #8524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia52bd1352b2c2b95628adbbc324f18dc4be367d9
Change-Id: Ib4611868b6fe747b2db5472bc8150e6284762f8c
Change-Id: I7ee2674e2252473e1cc6b0edc596976f72e4e241
Change-Id: I306ce443ac7ee93319efb9ae53c9c7e59a9ae006
Change-Id: I800b3661b24057316cbb537d51e6ba346cc30f45
|
That was fast! Thank you ! |
Closed
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Successfully tested to build Tensorflow's Android app on `4f9ae09cff5f357eb8260c468fbf22828f58e4b6` (HEAD today) with `bazel-dev build //tensorflow/examples/android:tensorflow_demo --cxxopt='--std=c++11' -c opt --fat_apk_cpu=x86,armeabi-v7a` This change includes: * Support for building with NDK 19 and 20 * Simplifying crosstool building by centralizing common configuration in `AndroidNdkCrosstoolsR19`. * Applying recommended flags documented in the [NDK Build System Maintainer's Guide](https://android.googlesource.com/platform/ndk/+/ndk-release-r19/docs/BuildSystemMaintainers.md#build-system-maintainers-guide) This change doesn't contain support for `lld` or use the new standalone GCC tools yet. These will come in a follow up PR. RELNOTES: Added support for Android NDK 19 and 20. Closes bazelbuild#8524. Change-Id: I800b3661b24057316cbb537d51e6ba346cc30f45 PiperOrigin-RevId: 250911997
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Successfully tested to build Tensorflow's Android app on `4f9ae09cff5f357eb8260c468fbf22828f58e4b6` (HEAD today) with `bazel-dev build //tensorflow/examples/android:tensorflow_demo --cxxopt='--std=c++11' -c opt --fat_apk_cpu=x86,armeabi-v7a` This change includes: * Support for building with NDK 19 and 20 * Simplifying crosstool building by centralizing common configuration in `AndroidNdkCrosstoolsR19`. * Applying recommended flags documented in the [NDK Build System Maintainer's Guide](https://android.googlesource.com/platform/ndk/+/ndk-release-r19/docs/BuildSystemMaintainers.md#build-system-maintainers-guide) This change doesn't contain support for `lld` or use the new standalone GCC tools yet. These will come in a follow up PR. RELNOTES: Added support for Android NDK 19 and 20. Closes bazelbuild#8524. Change-Id: I800b3661b24057316cbb537d51e6ba346cc30f45 PiperOrigin-RevId: 250911997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested to build Tensorflow's Android app on
4f9ae09cff5f357eb8260c468fbf22828f58e4b6(HEAD today) withbazel-dev build //tensorflow/examples/android:tensorflow_demo --cxxopt='--std=c++11' -c opt --fat_apk_cpu=x86,armeabi-v7aThis change includes:
AndroidNdkCrosstoolsR19.This change doesn't contain support for
lldor use the new standalone GCC tools yet. These will come in a follow up PR.RELNOTES: Added support for Android NDK 19 and 20.