Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java.desktop module from building the embedded JDK. #8085

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .bazelci/postsubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ platforms:
- "//tools/aquery_differ/..."
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1604:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -40,6 +42,8 @@ platforms:
- "//tools/aquery_differ/..."
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -60,6 +64,8 @@ platforms:
- "//tools/aquery_differ/..."
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_nojava:
build_flags:
- "--javabase=@openjdk_linux_archive//:runtime"
Expand Down Expand Up @@ -119,6 +125,8 @@ platforms:
- "-//src/tools/singlejar:zip64_test"
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java9:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -139,6 +147,8 @@ platforms:
- "//tools/aquery_differ/..."
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java10:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -159,6 +169,8 @@ platforms:
- "//tools/aquery_differ/..."
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java11:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -184,6 +196,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_bootstrap_distfile_test"
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
macos:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand Down Expand Up @@ -213,6 +227,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_cc_code_coverage_test"
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
windows:
batch_commands:
- powershell -Command "(Get-Content WORKSPACE) -Replace '# android_', 'android_' | Set-Content WORKSPACE"
Expand All @@ -236,6 +252,8 @@ platforms:
- "//src:all_windows_tests"
# TODO(iirina): Re-enable after #7952 was released.
- "-//src/test/shell/bazel:embedded_tools_deps_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
rbe_ubuntu1604:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/'
Expand Down
18 changes: 18 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/4663
- "-//src/test/shell/bazel/android:android_ndk_integration_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1604:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -48,6 +50,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/4663
- "-//src/test/shell/bazel/android:android_ndk_integration_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -72,6 +76,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/4663
- "-//src/test/shell/bazel/android:android_ndk_integration_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_nojava:
build_flags:
- "--javabase=@openjdk_linux_archive//:runtime"
Expand Down Expand Up @@ -133,6 +139,8 @@ platforms:
- "-//src/test/shell/integration:stub_finds_runfiles_test"
- "-//src/test/shell/integration:test_test"
- "-//src/tools/singlejar:zip64_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java9:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -157,6 +165,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/4663
- "-//src/test/shell/bazel/android:android_ndk_integration_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java10:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand All @@ -181,6 +191,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/4663
- "-//src/test/shell/bazel/android:android_ndk_integration_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
ubuntu1804_java11:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand Down Expand Up @@ -210,6 +222,8 @@ platforms:
- "-//src/test/shell/bazel:maven_test"
# Re-enable once bootstrap works with Java 11
- "-//src/test/shell/bazel:bazel_bootstrap_distfile_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
macos:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
Expand Down Expand Up @@ -254,6 +268,8 @@ platforms:
- "-//src/test/shell/bazel/android:aar_integration_test"
- "-//src/test/shell/bazel/android:android_integration_test"
- "-//src/test/shell/integration:minimal_jdk_test"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
windows:
batch_commands:
- powershell -Command "(Get-Content WORKSPACE) -Replace '# android_', 'android_' | Set-Content WORKSPACE"
Expand All @@ -275,6 +291,8 @@ platforms:
test_targets:
- "--"
- "//src:all_windows_tests"
# TODO(twerth): Re-enable after java.desktop has been removed.
- "-//src/test/shell/bazel:jdeps_test"
rbe_ubuntu1604:
shell_commands:
- sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/'
Expand Down
1 change: 0 additions & 1 deletion src/jdeps_modules.golden
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
java.base
java.compiler
java.desktop
java.instrument
java.logging
java.management
Expand Down