Zip Java tools for windows #7708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lberki
reviewed
Mar 14, 2019
third_party/zip_files.sh
Outdated
| tmp_dir=$(mktemp -d -t 'tmpdirXXXXX') | ||
| tmp_zip="$tmp_dir/archive.zip" | ||
|
|
||
| zip -j -q "$tmp_zip" "$@" |
There was a problem hiding this comment.
sort input files for determinism; consider using -D
third_party/zip_files.sh
Outdated
|
|
||
| mkdir -p "$tmp_dir/$directory_structure" | ||
| cd "$tmp_dir/$directory_structure" | ||
| unzip -q "$tmp_zip" |
There was a problem hiding this comment.
Why unzip and zip again?
There was a problem hiding this comment.
I am unzipping everything under the given directory_prefixso that when zipping directory_prefix the zip content has the same directory structure. I couldn't find a way to get the same results only by using zip. If you have any experience with this I'm happy to replace this part of the script.
|
@lberki all comments addressed, ready for re-review |
lberki
approved these changes
Mar 18, 2019
bazel-io
pushed a commit
that referenced
this pull request
Mar 18, 2019
Create a zip archive for the remote Java tools for Windows instead of a tar, which can not be parsed on some other platforms. Bazel doesn't have the equivalent of a `pkg_zip` rule and this PR introduces two new scripts that use `zip` directly: `third_party/merge_zip_files.sh`: merges all the given `zip` files into a single `zip` `third_party/zip_files.sh`: archives all the inputs files under the given directory structure in the output `zip` file Partial merge of #7708. PiperOrigin-RevId: 238969545
bazel-io
pushed a commit
that referenced
this pull request
Mar 19, 2019
Partial commit of third_party/*. See #7708. Signed-off-by: iirina <[email protected]>
|
All changes merged. |
philwo
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a zip archive for the remote Java tools for Windows instead of a tar, which can not be parsed on some other platforms.
Bazel doesn't have the equivalent of a
pkg_ziprule and this PR introduces two new scripts that usezipdirectly:third_party/merge_zip_files.sh: merges all the givenzipfiles into a singlezipthird_party/zip_files.sh: archives all the inputs files under the given directory structure in the outputzipfile