Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Bash is no longer required for everything #7666

Closed

Conversation

laszlocsomor
Copy link
Contributor

Bazel no longer reports an error if it fails to
locate Bash. This allows "bazel info release" to
work even in absence of Bash.

To clarify, Bazel still requires Bash to build
rules that depend on Bash. This PR simply removes
the fatal error Bazel used to display if Bash was
missing even when Bash was not required.

Fixes #6462

Bazel no longer reports an error if it fails to
locate Bash. This allows "bazel info release" to
work even in absence of Bash.

To clarify, Bazel still requires Bash to build
rules that depend on Bash. This PR simply removes
the fatal error Bazel used to display if Bash was
missing even when Bash was not required.

Fixes bazelbuild#6462
@laszlocsomor laszlocsomor changed the title WIP: Windows: Bash is no longer required for everything Windows: Bash is no longer required for everything Mar 7, 2019
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@bazel-io bazel-io closed this in 087fea1 Mar 7, 2019
@laszlocsomor laszlocsomor deleted the bash-not-required-for-info branch March 7, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants