Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove third_party/java/langtools from the bazel binary. #7492

Closed
wants to merge 1 commit into from
Closed

Remove third_party/java/langtools from the bazel binary. #7492

wants to merge 1 commit into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Feb 21, 2019 •
edited
Loading

This was part of #7472 but was reverted by mistake by 9192ee3

The bazel binary gets down to 94M. 😃

Progress on #6316.

@iirina iirina requested a review from meisterT February 21, 2019 15:12
meisterT
meisterT approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please mention #6316 in the CL description.

@bazel-io bazel-io closed this in 6de89a8 Feb 21, 2019
bazel-io pushed a commit that referenced this pull request Feb 21, 2019
@meisterT @copybara-github
Build bazel release binaries with -c opt.
cc004fb 
This saves ~5MB on every platform, new sizes:
104MB on Linux
107MB on Mac
98MB on Windows

#7492 will probably land before this and reduce size by another ~10MB, so we should be below 100MB on every platform!

Progress on #6314.

RELNOTES: None

Closes #7494.

PiperOrigin-RevId: 235010390
@philwo philwo deleted the remove-embedded-langtools branch June 20, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iirina @meisterT @googlebot