Explicitly add jdk.crypto.ec to the list of modules. #7337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
changed the title
|
We not rather add one more module and support TLSv1.3 (jdk.crypto.ec). |
philwo
reviewed
Feb 3, 2019
src/minimize_jdk.sh
Outdated
| @@ -24,6 +24,9 @@ if [ "$1" == "--allmodules" ]; then | |||
| modules="ALL-MODULE-PATH" | |||
| else | |||
| modules=$(cat "$2" | paste -sd "," - | tr -d '\r') | |||
| # We have to add this module explicitly because jdeps doesn't find the | |||
| # dependency on it but it still necessary for TLSv1.3. | |||
philwo
approved these changes
Feb 3, 2019
This is necessary because TLSv1.3 needs that module, but jdeps doesn't list this in the reduced modules list. Without that we get handshake errors while downloading stuff from github external repositories. RELNOTES: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 11 adds support for TLSv1.3 but the handshake while downloading from
github fails while download external repositories.
RELNOTES: Explicitly set https.protocols and exclude TLSv1.3.