Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.0] Fix bootstrap test by setting C++ standard to c++17 #25410

Open
wants to merge 1 commit into
base: release-8.2.0
Choose a base branch
from

Conversation

bazel-io
Copy link
Member

The apple_support toolchain doesn't pass -std=c++17 by default (like the rules_cc toolchain did), which broke boostrapping on macOS.

Closes #25407.

PiperOrigin-RevId: 731754906
Change-Id: Ida37babf9837a8e841b31d1d64e2e47376f37fe1

Commit 1fb8371

The `apple_support` toolchain doesn't pass `-std=c++17` by default (like the `rules_cc` toolchain did), which broke boostrapping on macOS.

Closes bazelbuild#25407.

PiperOrigin-RevId: 731754906
Change-Id: Ida37babf9837a8e841b31d1d64e2e47376f37fe1
@bazel-io bazel-io requested a review from a team as a code owner February 27, 2025 17:31
@bazel-io bazel-io added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 27, 2025
@iancha1992 iancha1992 enabled auto-merge February 27, 2025 17:59
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants