Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use coverage_output_generator-v2.8 #25200

Closed
wants to merge 1 commit into from

Conversation

c-mita
Copy link
Member

@c-mita c-mita commented Feb 5, 2025

Built at commit ee12906

Relevant changes:

RELNOTES:
LCOV parsing does not break on FN lines including an end line number.

Built at commit ee12906

Relevant changes:

    * Add support for input FN lines that include a function end line
      (bazelbuild#25118)

RELNOTES:
    LCOV parsing does not break on FN lines including an end line number
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 5, 2025
@c-mita c-mita requested review from meteorcloudy and fmeum February 5, 2025 11:08
@c-mita c-mita added the coverage label Feb 5, 2025
@c-mita c-mita self-assigned this Feb 5, 2025
@fmeum
Copy link
Collaborator

fmeum commented Feb 5, 2025

@bazel-io fork 8.1.0

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 5, 2025
@copybara-service copybara-service bot closed this in df92905 Feb 5, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 5, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 5, 2025
Built at commit ee12906

Relevant changes:

 * Add support for input FN lines that include a function end line (bazelbuild#25118).

RELNOTES:
    LCOV parsing does not break on FN lines including an end line number.

Closes bazelbuild#25200.

PiperOrigin-RevId: 723451534
Change-Id: I8912082ae6517bf0359329004d9a4f5e9ac76188
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
Built at commit ee12906

Relevant changes:

* Add support for input FN lines that include a function end line
(#25118).

RELNOTES:
LCOV parsing does not break on FN lines including an end line number.

Closes #25200.

PiperOrigin-RevId: 723451534
Change-Id: I8912082ae6517bf0359329004d9a4f5e9ac76188

Commit
df92905

Co-authored-by: Charles Mita <[email protected]>
@aignas
Copy link

aignas commented Feb 6, 2025

I know that the 7.5 got released, but this is impacting rules_python coverage support for the latest versions and it would be great if this could be included in a 7.x branch release as well if there are any future 7.x releases.

@fmeum
Copy link
Collaborator

fmeum commented Feb 6, 2025

@c-mita What do you think of extracting coverage tools into their own module (possibly together with the test runners)? Then users could update independently from Bazel and architecture-specific builds such as native images would become usable.

Cc @meteorcloudy

@meteorcloudy
Copy link
Member

@aignas Hmm,, it's likely there will be no next minor release for Bazel 7, we should probably encourage people to migrate to Bazel 8?

@aignas
Copy link

aignas commented Feb 6, 2025

I agree about urging people to upgrade, but at the same time it usually takes a lot of time for people to upgrade.

I think this particular change could be treated as a bug fix, so maybe it could fit into 7.5.1?

But if you have no plans to allocate resources for a patch release' I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants