Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve order of exec groups, toolchain types and exec constraints #25175

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 3, 2025

Using collection types that aren't guaranteed to preserve insertion order risks errors that differ across machines or builds.

Using collection types that aren't guaranteed to preserve insertion order risks errors that differ across machines or builds.
@fmeum fmeum requested a review from a team as a code owner February 3, 2025 11:49
@fmeum fmeum requested review from aranguyen and katre and removed request for a team and aranguyen February 3, 2025 11:49
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Feb 3, 2025
@katre katre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 3, 2025
@copybara-service copybara-service bot closed this in 2ee6f92 Feb 3, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 3, 2025
@fmeum fmeum deleted the deterministic-exec-groups branch February 3, 2025 22:25
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 3, 2025

@bazel-io fork 8.1.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 3, 2025
Using collection types that aren't guaranteed to preserve insertion order risks errors that differ across machines or builds.

Closes bazelbuild#25175.

PiperOrigin-RevId: 722768825
Change-Id: Id84c6b5b4bc9a1e6938de727e07c20ee761cbf3d
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2025
…raints (#25182)

Using collection types that aren't guaranteed to preserve insertion
order risks errors that differ across machines or builds.

Closes #25175.

PiperOrigin-RevId: 722768825
Change-Id: Id84c6b5b4bc9a1e6938de727e07c20ee761cbf3d

Commit
2ee6f92

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants