Add no_match_error attribute to toolchain_type
#25134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Configurability
RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required.
fmeum
force-pushed
the
12318-toolchain-error-message
branch
from
d059e07 to
b60a0f4
Compare
katre
approved these changes
Jan 29, 2025
katre
added
awaiting-PR-merge
|
@bazel-io fork 8.1.0 |
Allenqel
approved these changes
Jan 30, 2025
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 3, 2025
Fixes bazelbuild#12318 RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required. Closes bazelbuild#25134. PiperOrigin-RevId: 722733008 Change-Id: I2ff51f7524325be1b70314bb2db24c829602f5fc
|
@bazel-io fork 8.1.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Feb 3, 2025
Fixes bazelbuild#12318 RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required. Closes bazelbuild#25134. PiperOrigin-RevId: 722733008 Change-Id: I2ff51f7524325be1b70314bb2db24c829602f5fc
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Fixes #12318 RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required. Closes #25134. PiperOrigin-RevId: 722733008 Change-Id: I2ff51f7524325be1b70314bb2db24c829602f5fc Commit d514705 Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Fixes #12318 RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required. Closes #25134. PiperOrigin-RevId: 722733008 Change-Id: I2ff51f7524325be1b70314bb2db24c829602f5fc Commit d514705 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12318
RELNOTES: The new
no_match_errorattribute ontoolchain_typecan be used to show a custom message when no matching toolchain is found for that type, but one is required.