Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update java_tools v13.15 / rules_java 8.8.0 #25048

Closed
wants to merge 11 commits into from
Closed

Update java_tools v13.15 / rules_java 8.8.0 #25048

wants to merge 11 commits into from

Conversation

iancha1992
Copy link
Member

@iancha1992 iancha1992 commented Jan 23, 2025 •
edited
Loading

@iancha1992
Copy link
Member Author

iancha1992 commented Jan 24, 2025 •
edited
Loading

I'll update the lockfiles in bazel 7.4.1. I think that's the issue

@iancha1992
Copy link
Member Author

iancha1992 commented Jan 24, 2025 •
edited
Loading

@hvadehra can you please take a look at the issue? The lockfiles have been updated in Bazel 7, but looks like it's still failing.

@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Jan 24, 2025
@iancha1992 iancha1992 mentioned this pull request Jan 24, 2025
Closed
@hvadehra
Copy link
Member

Bazel is now using 8.0.1 to build (https://github.com/bazelbuild/bazel/blob/master/.bazelversion), so the earlier state was probably correct. The test failures if any will need investigation.
Could you please regenerate the lock files with Bazel 8.0.1?

@iancha1992
Copy link
Member Author

Bazel is now using 8.0.1 to build (https://github.com/bazelbuild/bazel/blob/master/.bazelversion), so the earlier state was probably correct. The test failures if any will need investigation. Could you please regenerate the lock files with Bazel 8.0.1?

Done @hvadehra

@hvadehra
Copy link
Member

@iancha1992 Could you please make a new java_tools RC from HEAD? (I pushed an improvement in b1d9c99)

@iancha1992
Copy link
Member Author

I'll update the lockfiles tomorrow morning.

@hvadehra
Copy link
Member

Please also rebase this branch on master HEAD.

@iancha1992
Copy link
Member Author

Please also rebase this branch on master HEAD.

Done. But looks like its failing.

@hvadehra

@hvadehra
Copy link
Member

@iancha1992 The java_tools release process does not overwrite existing files while uploading the archives.
You will need to create an rc2 for it to pick up the new version (this is still using the old java_tools rc1 built at ffc2989).

@iancha1992
Copy link
Member Author

@iancha1992 The java_tools release process does not overwrite existing files while uploading the archives. You will need to create an rc2 for it to pick up the new version (this is still using the old java_tools rc1 built at ffc2989).

I see. I did not know that. I'll do rc2 then. Thanks for letting me know.

@iancha1992
Copy link
Member Author

@hvadehra Looks like it's all passed now. I'm running the downstream at: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4432. I'll let you know if it looks good. Thanks

@iancha1992
Copy link
Member Author

@hvadehra Looks like it's all passed now. I'm running the downstream at: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4432. I'll let you know if it looks good. Thanks

Downstream looks good. @hvadehra

@hvadehra
Copy link
Member

Great, thanks a lot for patiently working through this!

@hvadehra
Copy link
Member

@iancha1992 I've made the rules_java v8.8.0 release.

@iancha1992
Copy link
Member Author

@hvadehra please let me know if this good for merge. Thanks!

hvadehra
hvadehra requested changes Jan 31, 2025
View reviewed changes
@iancha1992 iancha1992 marked this pull request as ready for review January 31, 2025 18:40
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 31, 2025
copybara-service bot pushed a commit that referenced this pull request Feb 3, 2025
@hvadehra @copybara-github
Fail in create_java_tools_release.sh instead of silently ignoring e…
e2ecfc0 
…xisting RCs

Context: #25048 (comment)
PiperOrigin-RevId: 722604130
Change-Id: I6766895e455916440d6fe28ad40299129f4bc31c
@iancha1992 iancha1992 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 3, 2025
@iancha1992
Copy link
Member Author

iancha1992 commented Feb 3, 2025 •
edited
Loading

@hvadehra do you want to cherry-pick this to release-8.1.0 as well? We are doing the rc1 tomorrow

@hvadehra
Copy link
Member

hvadehra commented Feb 4, 2025

@hvadehra do you want to cherry-pick this to release-8.1.0 as well? We are doing the rc1 tomorrow

cc @fmeum

@fmeum
Copy link
Collaborator

fmeum commented Feb 4, 2025

What would be needed to make progress is bazelbuild/rules_java#270, so if that doesn't make it in time, 8.8.0 isn't necessary either.

@copybara-service copybara-service bot closed this in e75acd1 Feb 4, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra hvadehra approved these changes

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iancha1992 @hvadehra @fmeum