Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1.0] Raise default --watchfs event limit #24872

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

bazel-io
Copy link
Member

@bazel-io bazel-io commented Jan 9, 2025

By default, the JDK only reports up to 500 events per WatchKey (and thus, per directory). This can be too low in large repos.

Work towards #13226

RELNOTES: On Linux, the default limit on the number of --watchfs file events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via --host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=<limit>.

Closes #23682.

PiperOrigin-RevId: 713570760
Change-Id: Ib3a61ad5d7cfaad4b7bbc25110f854e978e7fa75

Commit 2280dba

By default, the JDK only reports up to 500 events per `WatchKey` (and thus, per directory). This can be too low in large repos.

Work towards bazelbuild#13226

RELNOTES: On Linux, the default limit on the number of `--watchfs` file events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via `--host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=<limit>`.

Closes bazelbuild#23682.

PiperOrigin-RevId: 713570760
Change-Id: Ib3a61ad5d7cfaad4b7bbc25110f854e978e7fa75
@bazel-io bazel-io requested a review from a team as a code owner January 9, 2025 08:50
@bazel-io bazel-io added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 9, 2025
@bazel-io bazel-io requested a review from meisterT January 9, 2025 08:50
@iancha1992 iancha1992 deleted the branch bazelbuild:release-8.1.0 January 14, 2025 16:32
@iancha1992 iancha1992 closed this Jan 14, 2025
@iancha1992 iancha1992 reopened this Jan 18, 2025
@iancha1992 iancha1992 enabled auto-merge (squash) January 18, 2025 22:55
@iancha1992 iancha1992 merged commit b293f86 into bazelbuild:release-8.1.0 Jan 18, 2025
45 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants