Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.5.0] Retry the cleanup of downloadAndExtract #24665

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[7.5.0] Retry the cleanup of downloadAndExtract #24665

merged 2 commits into from
Dec 16, 2024

Conversation

bazel-io
Copy link
Member

This helps the HTTP downloader better cope with filesystems where unlink is non-atomic.

Closes #24295.

PiperOrigin-RevId: 697920434
Change-Id: I91b4dbf07a2efdca07c0310e15aac5f4d89c4091

Commit 99a27f6

@sthornington @bazel-io
Retry the cleanup of downloadAndExtract
482da4e 
This helps the HTTP downloader better cope with filesystems where unlink is non-atomic.

Closes bazelbuild#24295.

PiperOrigin-RevId: 697920434
Change-Id: I91b4dbf07a2efdca07c0310e15aac5f4d89c4091
@bazel-io bazel-io requested a review from a team as a code owner December 12, 2024 17:00
@bazel-io bazel-io added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Dec 12, 2024
@bazel-io bazel-io requested a review from Wyverald December 12, 2024 17:00
@bazel-io bazel-io mentioned this pull request Dec 12, 2024
Closed
@iancha1992 iancha1992 enabled auto-merge (squash) December 12, 2024 18:36
@iancha1992 iancha1992 mentioned this pull request Dec 12, 2024
Closed
@meteorcloudy
Copy link
Member

meteorcloudy commented Dec 13, 2024 •
edited
Loading

@iancha1992 Please backport be2186f and 9b027c8 to fix the windows failures.

@iancha1992 iancha1992 mentioned this pull request Dec 13, 2024
Merged
@sthornington
Copy link
Contributor

The moment this is merged I'm going to switch our bazelisk to it! :)

@iancha1992 iancha1992 merged commit aab0733 into bazelbuild:release-7.5.0 Dec 16, 2024
50 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 16, 2024
@sthornington
Copy link
Contributor

🎉

@sthornington
Copy link
Contributor

sthornington commented Dec 17, 2024 •
edited
Loading

Thanks - looks like it might need 5b54c74 to pass CI ?

Failure: https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/0193d0ec-392b-43e5-b0e1-374dfa4448c7/tools%5Cbuild_defs%5Cpkg%5Cpath_test%5Ctest_attempts%5Cattempt_1.log

@sthornington
Copy link
Contributor

I created #24728 in case that helps with some automation, but I can't set the release or milestone so probably it doesn't help... @iancha1992

@iancha1992 iancha1992 mentioned this pull request Dec 17, 2024
Merged
@sthornington
Copy link
Contributor

Got a clean CI hash for bazelisk, early Christmas present. Thanks everyone that helped with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bazel-io @meteorcloudy @sthornington @iancha1992