Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Add --inject_repository and fix crash on overridden non-existent repo #24301

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Wyverald
Copy link
Member

Suggest the new flag instead of crashing when --override_repository is applied to a non-existent repo with --noenable_workspace.

Fixes #22691

RELNOTES: The new --inject_repository flag can be used to add new repositories via the CLI with --enable_bzlmod. Such repositories behave as if they were declared by local_repository via use_repo_rule in the root module.

Closes #23791.

PiperOrigin-RevId: 695848897
Change-Id: I92ed25261c92d07f289815fcf6a65485ff43f373

Suggest the new flag instead of crashing when `--override_repository` is applied to a non-existent repo with `--noenable_workspace`.

Fixes #22691

RELNOTES: The new `--inject_repository` flag can be used to add new repositories via the CLI with `--enable_bzlmod`. Such repositories behave as if they were declared by `local_repository` via `use_repo_rule` in the root module.

Closes #23791.

PiperOrigin-RevId: 695848897
Change-Id: I92ed25261c92d07f289815fcf6a65485ff43f373
@Wyverald Wyverald requested a review from a team as a code owner November 12, 2024 21:30
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Nov 12, 2024
@iancha1992 iancha1992 changed the title Add --inject_repository and fix crash on overridden non-existent repo [8.0.0] Add --inject_repository and fix crash on overridden non-existent repo Nov 12, 2024
@Wyverald Wyverald added this pull request to the merge queue Nov 12, 2024
Merged via the queue into release-8.0.0 with commit 4d6fd93 Nov 12, 2024
48 checks passed
@Wyverald Wyverald deleted the wyv-cp-8d02d47 branch November 12, 2024 22:30
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants