Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Observe --noexperimental_check_output_files even for run commands. #24224

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[8.0.0] Observe --noexperimental_check_output_files even for run commands. #24224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,12 +519,9 @@ private ModifiedFileSet startBuildAndDetermineModifiedOutputFiles(
informedOutputServiceToStartTheBuild = true;
}
if (!request.getPackageOptions().checkOutputFiles) {
// Do not skip output invalidation in the following cases:
// 1. If the output tree is empty: this can happen after it's cleaned or corrupted.
// 2. For a run command: so that outputs are downloaded even if they were previously built
// with --remote_download_minimal. See https://github.com/bazelbuild/bazel/issues/20843.
if (!modifiedOutputFiles.treatEverythingAsDeleted()
&& !request.getCommandName().equals("run")) {
// Do not skip output invalidation if the output tree is empty: this can happen after it's
// cleaned or corrupted.
if (!modifiedOutputFiles.treatEverythingAsDeleted()) {
return ModifiedFileSet.NOTHING_MODIFIED;
}
}
Expand Down
Loading