Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Prevent excessive thread creation in disk cache garbage collection #24113

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bazel-io
Copy link
Member

Fixes #24098

With this change the disk cache garbage collection works correctly:

241027 09:06:34.732:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Disk cache garbage collection started
241027 09:07:06.123:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Deleted 190243 of 446229 files, reclaimed 5.4 GiB of 15.4 GiB

Closes #24099.

PiperOrigin-RevId: 690652512
Change-Id: Ie8d1fa6b2afb0bd5bd85fdb6835871023a64ad24

Commit 3746583

Fixes bazelbuild#24098

With this change the disk cache garbage collection works correctly:
```
241027 09:06:34.732:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Disk cache garbage collection started
241027 09:07:06.123:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Deleted 190243 of 446229 files, reclaimed 5.4 GiB of 15.4 GiB
```

Closes bazelbuild#24099.

PiperOrigin-RevId: 690652512
Change-Id: Ie8d1fa6b2afb0bd5bd85fdb6835871023a64ad24
@bazel-io bazel-io requested a review from a team as a code owner October 28, 2024 17:00
@bazel-io bazel-io added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc awaiting-review PR is awaiting review from an assigned reviewer labels Oct 28, 2024
@iancha1992 iancha1992 requested a review from tjgq October 28, 2024 17:04
@iancha1992 iancha1992 enabled auto-merge October 28, 2024 17:04
@iancha1992 iancha1992 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into bazelbuild:release-8.0.0 with commit ea35fc8 Oct 28, 2024
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 28, 2024
@Wyverald Wyverald deleted the cp24098-8.0.0 branch October 28, 2024 20:35
@iancha1992 iancha1992 added this to the 8.0.0 release blockers milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants