[7.3.1] Fix expected lockfile version to change based on --incompatible_use_plus_in_repo_names
#23281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble_use_plus_in_repo_names` We write a different lockfile version based on `--incompatible_use_plus_in_repo_names` (see HACK in `BazelLockFileModule.java`). But we don't _expect_ a different lockfile version based on that flag; this causes us to consider the lockfile _always_ out-of-date when that flag is set. Fixes #23279.
Wyverald
force-pushed
the
wyv-731-lockversion
branch
from
3ce6549 to
2877175
Compare
github-actions
bot
added
awaiting-review
meteorcloudy
approved these changes
Aug 13, 2024
github-actions
bot
removed
the
awaiting-review
fmeum
approved these changes
Aug 13, 2024
Sec32fun32
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We write a different lockfile version based on
--incompatible_use_plus_in_repo_names(see HACK inBazelLockFileModule.java). But we don't expect a different lockfile version based on that flag; this causes us to consider the lockfile always out-of-date when that flag is set.Fixes #23279.