Allow longpath executables #22532
Open
Allow longpath executables #22532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demiguise
force-pushed
the
allow_longpath_executables
branch
from
25bc69a to
5879ac7
Compare
jerome-blanche
added a commit
to jerome-blanche/bazel
that referenced
this pull request
Sep 10, 2024
github-actions
bot
added
the
awaiting-review
There was a problem hiding this comment.
All looks reasonable to me, thanks for the contribution!
Can you please add a test in https://cs.opensource.google/bazel/bazel/+/master:src/test/py/bazel/bazel_windows_test.py?
| stem.remove_suffix(1); | ||
| } | ||
|
|
||
| std::wstring wrapper_file_name = std::wstring(stem) + L".wrapper.bat"; |
There was a problem hiding this comment.
This might be risk of conflict with existing file or lack of write permission? Can we find a safer place to create the wrapper?
meteorcloudy
added
the
team-OSS
Sure, will also try and fix the string view compilation failures ;.; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into #19710 when we started to tinker with the Python rules and bazel, as we were running into extremely long execution times when running anything related to Python (45-60s). Disabling Python zipping and enabling runfiles on windows brought the execution times down and made them comparable to MacOS/Linux, which was a huge win.
Only issue is that the runfiles then ran straight into the wonderful longpath problems from the linked issue when running tests that now used runfiles. If 8dot3 names are not turned on, or there is no short path associated with the given path, then the AsShortPath function will fail. Even though "Technically" long paths could be enabled and windows could actually still execute the requested executable.
Although CreateProcessW has the MAX_PATH limit built into it, which can never be worked around, batch files seemingly do not have this issue. So, we can simply dump the requested command line into a batch file and redirect the command line to run that batch file instead.
This is a similar approach to CMake/Ninja when a CustomCommand is over a certain (8192) character limit. In that situation they create a new batch file that has the command inside and ensure that the Ninja target just runs that file instead.