-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce file name format for MODULE.bazel includes #22075
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They must end in `.MODULE.bazel`. Follow-up for #17880
github-actions
bot
added
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 22, 2024
meteorcloudy
approved these changes
Apr 22, 2024
meteorcloudy
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 22, 2024
fmeum
approved these changes
Apr 22, 2024
fmeum
added a commit
to fmeum/buildtools
that referenced
this pull request
Apr 22, 2024
After bazelbuild/bazel#22075, these are the files that can be `include()`ed into `MODULE.bazel` files and should be formatted and edited just like them.
fmeum
added a commit
to fmeum/buildtools
that referenced
this pull request
Apr 22, 2024
After bazelbuild/bazel#22075, these are the files that can be `include()`ed into `MODULE.bazel` files and should be formatted and edited just like them.
Wyverald
pushed a commit
to bazelbuild/buildtools
that referenced
this pull request
Apr 22, 2024
After bazelbuild/bazel#22075, these are the files that can be `include()`ed into `MODULE.bazel` files and should be formatted and edited just like them.
sgowroji
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Apr 26, 2024
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
After bazelbuild/bazel#22075, these are the files that can be `include()`ed into `MODULE.bazel` files and should be formatted and edited just like them.
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
They must end in `.MODULE.bazel`. Follow-up for bazelbuild#17880 Closes bazelbuild#22075. PiperOrigin-RevId: 627136756 Change-Id: If9b1797f2e7ddc1aebd929646329e832288bfd8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They must end in
.MODULE.bazel
.Follow-up for #17880