Do not record or check repo mapping entries for repos defined in WORKSPACE #21393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SPACE Mappings for repos defined in WORKSPACE are extremely annoying to verify given the chunked loading (we'd have to record which chunk the repo mapping was used in, and then load that chunk while verifying). This is extremely not worth the effort (especially since nobody really uses repo mappings in WORKSPACE) so we just don't record it. This also means, during verification, we can safely use the main repo mapping without WORKSPACE (since repos defined in Bzlmod can't see stuff from WORKSPACE anyway). Fixes #21289.
github-actions
bot
added
team-ExternalDeps
fmeum
approved these changes
Feb 16, 2024
|
@Wyverald mind assigning this review to someone else? I'd have to get up to speed on the intricacies of module extensions etc. to review this change (I should do that eventually anyways and I can do that now if there is no other option). Maybe @SalmaSamy ? |
github-actions
bot
removed
the
awaiting-review
Wyverald
added a commit
that referenced
this pull request
Feb 20, 2024
…SPACE Mappings for repos defined in WORKSPACE are extremely annoying to verify given the chunked loading (we'd have to record which chunk the repo mapping was used in, and then load that chunk while verifying). This is extremely not worth the effort (especially since nobody really uses repo mappings in WORKSPACE) so we just don't record it. This also means, during verification, we can safely use the main repo mapping without WORKSPACE (since repos defined in Bzlmod can't see stuff from WORKSPACE anyway). Fixes #21289. Closes #21393. PiperOrigin-RevId: 608258493 Change-Id: Ife6a01221e6f5e1685d859eaa5acc8b370ab8483
Wyverald
added a commit
that referenced
this pull request
Feb 20, 2024
…SPACE Mappings for repos defined in WORKSPACE are extremely annoying to verify given the chunked loading (we'd have to record which chunk the repo mapping was used in, and then load that chunk while verifying). This is extremely not worth the effort (especially since nobody really uses repo mappings in WORKSPACE) so we just don't record it. This also means, during verification, we can safely use the main repo mapping without WORKSPACE (since repos defined in Bzlmod can't see stuff from WORKSPACE anyway). Fixes #21289. Closes #21393. PiperOrigin-RevId: 608258493 Change-Id: Ife6a01221e6f5e1685d859eaa5acc8b370ab8483
rrbutani
pushed a commit
to rrbutani/bazel
that referenced
this pull request
Feb 28, 2024
…SPACE Mappings for repos defined in WORKSPACE are extremely annoying to verify given the chunked loading (we'd have to record which chunk the repo mapping was used in, and then load that chunk while verifying). This is extremely not worth the effort (especially since nobody really uses repo mappings in WORKSPACE) so we just don't record it. This also means, during verification, we can safely use the main repo mapping without WORKSPACE (since repos defined in Bzlmod can't see stuff from WORKSPACE anyway). Fixes bazelbuild#21289. Closes bazelbuild#21393. PiperOrigin-RevId: 608258493 Change-Id: Ife6a01221e6f5e1685d859eaa5acc8b370ab8483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mappings for repos defined in WORKSPACE are extremely annoying to verify given the chunked loading (we'd have to record which chunk the repo mapping was used in, and then load that chunk while verifying). This is extremely not worth the effort (especially since nobody really uses repo mappings in WORKSPACE) so we just don't record it.
This also means, during verification, we can safely use the main repo mapping without WORKSPACE (since repos defined in Bzlmod can't see stuff from WORKSPACE anyway).
Fixes #21289.