Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlmod: support git repos in source.json #20912

Closed
wants to merge 17 commits into from

Conversation

nachumg
Copy link
Contributor

@nachumg nachumg commented Jan 16, 2024

bzlmod: support git repos in source.json

Change-Id: I2bf5a06229c412a8fcf8265acdf5e5406f8ef694
Change-Id: I8d34cfb81256921070e9311798a549a49cdf6a33
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jan 16, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meteorcloudy
Copy link
Member

Please fix the failing test in presubmit

Change-Id: I8d34cfb81256921070e9311798a549a49cdf6a33
@nachumg
Copy link
Contributor Author

nachumg commented Jan 17, 2024

Please fix the failing test in presubmit

Done.

nachumg and others added 6 commits January 17, 2024 14:15
Change-Id: I8d34cfb81256921070e9311798a549a49cdf6a33
Change-Id: Ibe70bc0518853c5cfcde17f000da7878a237b421
Change-Id: If7043a2d3a6fbe9724f57d3e64132cec93a5b0a6
Change-Id: I90f44b03fb215425b19424573927c3a575abd486
Change-Id: I2a2e7abe5beb91b5dce665c9cd13ebbd5319d250
Change-Id: I5d158550762d13f57d90d3686e2d82a759ff9bb1
Change-Id: Ia32ea8454636d349a2708ecc59f12c2a1b245c1c
site/en/external/registry.md Outdated Show resolved Hide resolved
Change-Id: I10109d7f225d5c52583f6c6c6325e807263553c6
Change-Id: Ia267131e6d081572a642888ba34e285805bbbe9f
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 24, 2024
@nachumg nachumg requested a review from meteorcloudy January 24, 2024 19:58
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 25, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jan 25, 2024

@bazel-io fork 7.1.0

Wyverald pushed a commit that referenced this pull request Jan 25, 2024
bzlmod: support git repos in source.json

Closes #20912.

Change-Id: Ia267131e6d081572a642888ba34e285805bbbe9f
PiperOrigin-RevId: 601268823
github-merge-queue bot pushed a commit that referenced this pull request Jan 26, 2024
bzlmod: support git repos in source.json

Closes #20912.

RELNOTES: Added `init_submodules` attribute to `git_override`.
Registries now support the `git_repository` type in `source.json`.

Change-Id: Ia267131e6d081572a642888ba34e285805bbbe9f
PiperOrigin-RevId: 601268823

---------

Co-authored-by: Nachum Goldstein <[email protected]>
Co-authored-by: Keith Smiley <[email protected]>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants