Flip --incompatible_merge_fixed_and_default_shell_env
#19318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
flip-incompatible_merge_fixed_and_default_shell_env
branch
2 times, most recently
from
ddb0c68
to
8c0df7f
Compare
fmeum
changed the title
--incompatible_merge_fixed_and_default_shell_env
fmeum
force-pushed
the
flip-incompatible_merge_fixed_and_default_shell_env
branch
from
8c0df7f
to
79c7f22
Compare
|
Downstream looks good: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1625 |
fmeum
force-pushed
the
flip-incompatible_merge_fixed_and_default_shell_env
branch
from
79c7f22
to
545a5ab
Compare
github-actions
bot
added
the
awaiting-review
|
@comius In addition to flipping the flag, I also updated the docs. |
comius
approved these changes
Aug 25, 2023
comius
added
awaiting-PR-merge
|
Thanks! I think this is low-risk for internal breakages. After import I'll let nightly testing figure that out. If it does, there might be a rollback in following days. |
iancha1992
added
the
team-Rules-API
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5980
Closes #19317
RELNOTES[INC]: --incompatible_merge_fixed_and_default_shell_env is flipped to true. See #19317 for details.