Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cc_test_wrapper to cc_test #18871

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 10, 2023

Previously, str(native.cc_test) included cc_test_wrapper, which is an implementation detail of cc_test.

Previously, `str(native.cc_test)` included `cc_test_wrapper`, which is
an implementation detail of `cc_test`.
@fmeum fmeum requested a review from buildbreaker2021 July 10, 2023 09:22
@fmeum fmeum marked this pull request as ready for review July 10, 2023 09:22
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 10, 2023
@buildbreaker2021 buildbreaker2021 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 10, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 10, 2023
@fmeum fmeum deleted the cc_test_wrapper branch July 10, 2023 13:58
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 10, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 10, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 10, 2023
@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label Aug 10, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Aug 10, 2023
Previously, `str(native.cc_test)` included `cc_test_wrapper`, which is an implementation detail of `cc_test`.

Closes bazelbuild#18871.

PiperOrigin-RevId: 546836622
Change-Id: I80e02a2be80ab01610c5848ab1cd506df11c9557
fmeum added a commit to fmeum/bazel that referenced this pull request Aug 11, 2023
Previously, `str(native.cc_test)` included `cc_test_wrapper`, which is an implementation detail of `cc_test`.

Closes bazelbuild#18871.

Commit 70e31da

PiperOrigin-RevId: 546836622
Change-Id: I80e02a2be80ab01610c5848ab1cd506df11c9557
iancha1992 pushed a commit that referenced this pull request Aug 16, 2023
Previously, `str(native.cc_test)` included `cc_test_wrapper`, which is
an implementation detail of `cc_test`.

Closes #18871.

Commit 70e31da

PiperOrigin-RevId: 546836622
Change-Id: I80e02a2be80ab01610c5848ab1cd506df11c9557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants