Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly account for symlinks and root symlinks in repo mapping manifest #18381

Closed
wants to merge 5 commits into from
+239 −88
Closed

Properly account for symlinks and root symlinks in repo mapping manifest #18381

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
441f1c0
Properly account for symlinks and root symlinks in repo mapping manifest
fmeum May 12, 2023
5fbc5bd
Improve comment
fmeum May 13, 2023
90863ef
Address review comment
fmeum May 17, 2023
13f680c
Address review comment
fmeum May 24, 2023
0c802b3
Update rules docs
fmeum Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comment
@fmeum
fmeum committed Jun 15, 2023
commit 13f680c332f18b235ffc45a435f91fab87e4191d
3 changes: 2 additions & 1 deletion src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetFingerprintCache.java
View file
Original file line number Diff line number Diff line change
@@ -79,7 +79,8 @@ public static <T> String describedNestedSetFingerprint(
return "<empty>";
}
StringBuilder sb = new StringBuilder();
sb.append("order: ").append(nestedSet.getOrder()).append('\n');
sb.append("order: ").append(nestedSet.getOrder()).append(" (fingerprinting considers internal" +
" nested set structure, which is not reflected in values reported below)\n");
ImmutableList<T> list = nestedSet.toList();
sb.append("size: ").append(list.size()).append('\n');
for (T item : list) {