Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest alternatives for typoed rule attribute names #17847

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Mar 22, 2023

No description provided.

@katre katre added type: feature request awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Mar 22, 2023
@katre
Copy link
Member

katre commented Mar 22, 2023

Sorry, jumped the gun because this is something I didn't even know we can do. :)

@fmeum fmeum force-pushed the did-you-mean-rule branch from eccf509 to 9c5c891 Compare March 22, 2023 15:05
@fmeum fmeum marked this pull request as ready for review March 22, 2023 15:12
@fmeum
Copy link
Collaborator Author

fmeum commented Mar 22, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 22, 2023
@katre katre added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 22, 2023
@Wyverald
Copy link
Member

@bazel-io fork 6.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 22, 2023
@ShreeM01 ShreeM01 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 22, 2023
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Mar 22, 2023
Closes bazelbuild#17847.

PiperOrigin-RevId: 518664847
Change-Id: I99d09be093e785c7d1ad437d40866423638be118
@fmeum fmeum deleted the did-you-mean-rule branch March 23, 2023 07:52
ShreeM01 added a commit that referenced this pull request Mar 23, 2023
Closes #17847.

PiperOrigin-RevId: 518664847
Change-Id: I99d09be093e785c7d1ad437d40866423638be118

Co-authored-by: Fabian Meumertzheim <[email protected]>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Closes bazelbuild#17847.

PiperOrigin-RevId: 518664847
Change-Id: I99d09be093e785c7d1ad437d40866423638be118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants