Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra resources #16785

Closed
wants to merge 2 commits into from
Closed

Extra resources #16785

wants to merge 2 commits into from

Conversation

drewmacrae
Copy link
Contributor

@drewmacrae drewmacrae commented Nov 17, 2022 •
edited
Loading

This recreates a closed PR to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

This was referenced Nov 17, 2022
Closed
Closed
@drewmacrae drewmacrae mentioned this pull request Nov 22, 2022
Closed
@drewmacrae drewmacrae marked this pull request as ready for review November 22, 2022 14:55
@sgowroji sgowroji added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc awaiting-review PR is awaiting review from an assigned reviewer labels Nov 22, 2022
@haxorz
Copy link
Contributor

haxorz commented Nov 29, 2022 •
edited
Loading

This PR touches the code that manages local action execution, hence I'm moving this to the team-Local-Exec label.

@haxorz haxorz added team-Local-Exec Issues and PRs for the Execution (Local) team and removed team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Nov 29, 2022
@wilwell wilwell self-requested a review December 6, 2022 14:51
@drewmacrae drewmacrae force-pushed the extra_resources branch 4 times, most recently from f1d4e72 to 255a1dc Compare December 10, 2022 17:40
@drewmacrae drewmacrae requested review from larsrc-google and wilwell and removed request for larsrc-google and wilwell December 10, 2022 17:56
scele and others added 2 commits December 10, 2022 14:29
@scele
Implement extra resources for test actions
1b13d2f 
Add support for user-specified resource types in the resource manager.
This generalizes the CPU, RAM and "test count" resource support for
other resource types such as the number of GPUs, available GPU memory,
the number of embedded devices connected to the host, etc.

The available amount of extra resources can be specified using the new
--local_extra_resources=<resourcename>=<amount> command line flag, which
is analoguous to the existing --local_cpu_resources and
--local_memory_resources flags.

Tests can then declare the amount of extra resources they need by using
a "resources:<resourcename>:<amount>" tag.
fixup Implement extra resources for test actions
ce23a5f 
Addressed comments on bazelbuild#13996
Fixed issues in tests and built and tested with
lowRISC/opentitan#16436

Signed-off-by: Drew Macrae <[email protected]>
@drewmacrae drewmacrae requested review from larsrc-google and wilwell and removed request for wilwell and larsrc-google December 14, 2022 14:15
drewmacrae pushed a commit to drewmacrae/opentitan that referenced this pull request Dec 23, 2022
[bazel] Allocate CW310s based on extra resources
a2232f3 
WIP requires custom bazel binary. Don't merge until bazel is updated to
reflect upstream changes.

Removes the external tag in preference for a custom resource as handled
by bazelbuild/bazel#16785

Signed-off-by: Drew Macrae <[email protected]>
@wilwell wilwell removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 30, 2022
drewmacrae pushed a commit to drewmacrae/bazel that referenced this pull request Jan 17, 2023
Extra resources
af59cd0 
This recreates a [closed PR](bazelbuild#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:bazelbuild#16817

Closes bazelbuild#16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
@drewmacrae drewmacrae mentioned this pull request Jan 17, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 19, 2023
@ShreeM01
Extra resources (#17229)
bcfc7f7 
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68

Co-authored-by: kshyanashree <[email protected]>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@hvadehra
Extra resources
455ec35 
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
@larsrc-google
Copy link
Contributor

larsrc-google commented Feb 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haxorz haxorz haxorz left review comments

@wilwell wilwell wilwell approved these changes

@larsrc-google larsrc-google Awaiting requested review from larsrc-google

Assignees
No one assigned
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drewmacrae @haxorz @larsrc-google @wilwell @sgowroji @scele