Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Further Rule Documentation #16372

Closed
wants to merge 2 commits into from
Closed

Add link to Further Rule Documentation #16372

wants to merge 2 commits into from

Conversation

aryeh-looker
Copy link
Contributor

@aryeh-looker aryeh-looker commented Oct 2, 2022 •
edited
Loading

Update https://bazel.build/rules/lib/rule to point to https://bazel.build/extending/rules for more information about rule(...).

Issue reference: #16373

@sgowroji sgowroji added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-user-response Awaiting a response from the author labels Oct 3, 2022
@sgowroji
Copy link
Member

sgowroji commented Nov 2, 2022

Hello @aryeh-looker, Can you please fix the above buildkite checks. Thanks!

@sgowroji
Copy link
Member

Hello @aryeh-looker, Above PR is awaiting to review as it is pending on your buildkite fixes update. Thanks!

@aryeh-looker aryeh-looker mentioned this pull request Nov 21, 2022
Closed
@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Nov 21, 2022
@sgowroji sgowroji self-requested a review November 22, 2022 03:35
sgowroji
sgowroji approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@sgowroji sgowroji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

@sgowroji sgowroji added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 22, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 22, 2022
copybara-service bot pushed a commit that referenced this pull request Dec 5, 2022
@copybara-github
Update CONTRIBUTORS
1dbf5ee 
Pending #16372

Closes #16809.

PiperOrigin-RevId: 492981010
Change-Id: I7430049131730ad48bff1e8c59c45e11bc4488cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgowroji sgowroji sgowroji approved these changes

Assignees
No one assigned
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryeh-looker @sgowroji