Use .dylib extension for macOS dynamic libraries in XCode toolchain #14369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to bazelbuild#14158. Fixes bazelbuild#11082. Closes bazelbuild#14354. PiperOrigin-RevId: 413885597 (cherrypicked from 6e1b440)
|
@meteorcloudy Could you merge #14360 and this PR for Bazel 5? |
|
@oquenchil Is this change safe to get into 5.0? |
|
We decided not to merge this for 5.0, see #14360 (comment) |
fmeum
added a commit
to CodeIntelligenceTesting/rules_foreign_cc
that referenced
this pull request
Dec 6, 2021
…acOS As of bazelbuild/bazel#14369, shared libraries produced with cc_binary on macOS with the auto-configured toolchain use the correct file extension for dynamic libraries (.dylib rather than .so). This requires adapting a test.
fmeum
added a commit
to CodeIntelligenceTesting/rules_foreign_cc
that referenced
this pull request
Dec 6, 2021
As of bazelbuild/bazel#14369, shared libraries produced with cc_binary on macOS with the auto-configured toolchain use the correct file extension for dynamic libraries (.dylib rather than .so). This requires adapting a test.
|
@meteorcloudy just so you're aware on macOS python C extensions require a |
|
I believe even with this PR, you can still create a shared library with a explicit |
UebelAndre
pushed a commit
to bazel-contrib/rules_foreign_cc
that referenced
this pull request
Dec 6, 2021
As of bazelbuild/bazel#14369, shared libraries produced with cc_binary on macOS with the auto-configured toolchain use the correct file extension for dynamic libraries (.dylib rather than .so). This requires adapting a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #14158.
Fixes #11082.
Closes #14354.
PiperOrigin-RevId: 413885597
(cherrypicked from 6e1b440)