Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_exec_properties to control test action #10866

Closed
wants to merge 2 commits into from

Conversation

werkt
Copy link
Contributor

@werkt werkt commented Feb 26, 2020

If specified for a test action, these properties will be added to the
effective exec_properties for a target, overriding any keys which match
by name, and only being effective for the test's execution, not any
other actions from the rule's context.

Closes #10799

If specified for a test action, these properties will be added to the
effective exec_properties for a target, overriding any keys which match
by name, and only being effective for the test's execution, not any
other actions from the rule's context.
@werkt werkt force-pushed the test_exec_properties branch from 72beb6a to 08aae95 Compare February 26, 2020 15:11
@sdtwigg
Copy link
Contributor

sdtwigg commented Feb 27, 2020

I am unsure about this change.

Regardless, I think you also need to add the attribute to SkylarkRuleClassFunctions.java in order for this to also work in Starlark test rules.

@werkt
Copy link
Contributor Author

werkt commented Feb 28, 2020

The associated issue should provide some additional explanation for this change. If there's already a way to target only test actions with per target property manipulations, I'm fine with that, but I don't believe there is.

Updated to support starlark test rules.

@gregestren
Copy link
Contributor

Hey @werkt. In the interest of moving this PR forward, I think the right next step is to get an update from @juliexxia, who's implemented a major chunk of the work discussed in #10799.

Let's aim to get her perspective next week, then decide the right way to close this from there.

@meisterT
Copy link
Member

What's the state of this PR?

@juliexxia
Copy link
Contributor

It's being replaced by an exec group to create test actions. Waiting on internal PR reviews.

@philwo
Copy link
Member

philwo commented Nov 10, 2020

@juliexxia I understand that we can thus close this PR. Please comment and reopen if this is wrong.

@philwo philwo closed this Nov 10, 2020
@werkt werkt deleted the test_exec_properties branch March 6, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_exec_properties differentiation
8 participants