Tweak third_party/BUILD for OpenBSD. #10639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
added
the
team-OSS
jmmv
reviewed
Feb 3, 2020
bazel-io
pushed a commit
that referenced
this pull request
Feb 4, 2020
Searching the `PATH` is the only feasible way to find the executable on OpenBSD when `argv[0]` is not an absolute path or a relative path. This change resolves a TODO. This change moves a preexisting `Which` function for searching the `PATH` out of `blaze_util_linux.cc` and into `blaze_util_posix.cc`, so that the Linux code and the BSD code can share this function. In my testing on OpenBSD 6.6-current, a bootstrap build of Bazel succeeds and the resulting `bazel` binary can find itself on the `PATH`. (One caveat: For the bootstrap build to succeed, I had to manually apply the unrelated change in #10639, since it's not merged yet.) This change is part of the OpenBSD port in #10250. @jmmv FYI. Closes #10691. PiperOrigin-RevId: 293183553
philwo
approved these changes
Feb 6, 2020
bazel-io
pushed a commit
that referenced
this pull request
Feb 6, 2020
Partial commit for third_party/*, see #10639. Signed-off-by: Philipp Wollermann <[email protected]>
|
Merged in e274da3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was part of #10567, which was merged as commit d6145a0, but somehow that commit contains all of the changes in the PR except the changes to
third_party/BUILD. Apparently the changes to that file were lost when the PR was imported into Google's internal code repository. Here is another PR for those changes that disappeared.@aehlig FYI.
This change is part of the OpenBSD port in #10250.