Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeFileValues apparently contain their own root directories sometimes #9058

Closed
lberki opened this issue Aug 2, 2019 · 4 comments
Closed

TreeFileValues apparently contain their own root directories sometimes #9058

lberki opened this issue Aug 2, 2019 · 4 comments
Assignees
@justinhorvitz
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc untriaged

Comments

@lberki
Copy link
Contributor

lberki commented Aug 2, 2019

#9054 is caused by an assertion that stipulates that TreeFileArtifacts only contain RegularFileValues.

This is apparently not true -- the file the assertion fails on, chromium.out is the root directory of the associated TreeArtifact.

For now, I'll just relax the assertion, but it would be nice to know how any why this happens.

Surprisingly, this is only an issue on OS X.
@irengrig
Copy link
Contributor

irengrig commented Aug 2, 2019

Assigning to @lberki.

@irengrig irengrig added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc untriaged labels Aug 2, 2019
@lberki lberki removed their assignment Aug 2, 2019
@lberki
Copy link
Contributor Author

lberki commented Aug 2, 2019

I can't promise to do this in any foreseeable amount of time so I'll unassign myself.

@justinhorvitz
Copy link
Contributor

Looks like this was the root cause of #11813

@justinhorvitz
Copy link
Contributor

Took a look into the chromium rules. It's creating a symlink to a directory within the tree artifact, and it's not actually the root directory. As far as I can tell, this is legal and should be supported. I also reproduced this on linux, so it's nothing mac-specific, just happens to be that the rule that does this is for mac.

@justinhorvitz justinhorvitz self-assigned this Jul 22, 2020
ehkloaj pushed a commit to ehkloaj/bazel that referenced this issue Aug 6, 2020
@justinhorvitz @ehkloaj
Add test coverage for tree artifacts containing directory symlinks.
d399222 
We have been bitten twice by this use case. See bazelbuild#9054 and bazelbuild#11813.

Fixes bazelbuild#9058.

RELNOTES: None.
PiperOrigin-RevId: 322590818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinhorvitz justinhorvitz

Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lberki @irengrig @justinhorvitz