Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-C doesn't interrupt fetching remote repositories #8346

Closed
lberki opened this issue May 16, 2019 · 4 comments
Closed

Ctrl-C doesn't interrupt fetching remote repositories #8346

lberki opened this issue May 16, 2019 · 4 comments
Assignees
@aehlig
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@lberki
Copy link
Contributor

lberki commented May 16, 2019 •
edited
Loading

Reproduction:

bazel query -k 'deps(@bazel_tools//...)'
# This starts downloading a lot of things
<Press Ctrl-C>

Then observe that the downloads are not stopped. It appears that #1226 regressed?
@lberki lberki added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels May 16, 2019
@aehlig
Copy link
Contributor

aehlig commented May 16, 2019

The reproduction case should be bazel query -k 'deps(@bazel_tools//...)'. The fact that @bazel_tools is not self-contained is a separate issue.

@aehlig aehlig mentioned this issue May 16, 2019
Closed
@lberki
Copy link
Contributor Author

lberki commented May 16, 2019

My bad. Let me update the repro instructions.

@lberki
Copy link
Contributor Author

lberki commented May 16, 2019 •
edited
Loading

(And yes, unresolved dependencies are an issue, too, but I figured filing one issue was enough for the day :) )

@aehlig
Copy link
Contributor

aehlig commented May 16, 2019

This is happening in the repository cache; disabling it (by setting --repository_cache=, i.e., by setting repository_cache to the empty string) will get downloads that get interrupted immediately.

@aehlig aehlig self-assigned this May 17, 2019
bazel-io pushed a commit that referenced this issue May 21, 2019
@aehlig @copybara-github
Support interruption in decompression
aa69a6e 
Decompressing large archives can take a while. Therefore, properly
honor interruption requests.

Improves on #8346.

Change-Id: I648bd1dc4b9e1f4b03065ffff3d9d66cd9cc92a1
PiperOrigin-RevId: 249246136
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@aehlig @irengrig
Support interruption in decompression
51296b2 
Decompressing large archives can take a while. Therefore, properly
honor interruption requests.

Improves on bazelbuild#8346.

Change-Id: I648bd1dc4b9e1f4b03065ffff3d9d66cd9cc92a1
PiperOrigin-RevId: 249246136
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@aehlig @irengrig
Allow interrupts while accessing the cache
cf22329 
Certain operations in the repository cache take some time, e.g.,
verifying the checksum of a file. Allow interrupts while doing so.

While touching SkylarkRepositoryContext.java anyway, remove dead code there.

Fixes bazelbuild#8346

Change-Id: I26bbdb314554271949a34555600df1c35cc1544d
PiperOrigin-RevId: 249253196
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aehlig aehlig

Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwo @lberki @aehlig