Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade //third_party/protobuf version to 3.7.0 #7611

Closed
davido opened this issue Mar 3, 2019 · 5 comments
Closed

Upgrade //third_party/protobuf version to 3.7.0 #7611

davido opened this issue Mar 3, 2019 · 5 comments
Assignees
@laszlocsomor
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@davido
Copy link
Contributor

davido commented Mar 3, 2019

Protobuf 3.7.0 was recently released: [1].

[1] https://github.com/protocolbuffers/protobuf/releases/tag/v3.7.0
@davido
Copy link
Contributor Author

davido commented Mar 3, 2019

Currently, the new release cannot be built with Bazel due to the missing dependency on Error Prone Annotations library, that was fixed here: [1].

[1] protocolbuffers/protobuf#5811

@aiuto aiuto added area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling untriaged labels Mar 6, 2019
@davido davido mentioned this issue Mar 8, 2019
Closed
davido added a commit to davido/bazel that referenced this issue Mar 9, 2019
@davido
Update protobuf to 3.7.1 (PR 1)
026afdb 
Closes bazelbuild#7611.

Change-Id: Ib6edee142ed3cf92806f2b63d119ae11ebe51a6f
davido added a commit to davido/bazel that referenced this issue Mar 9, 2019
@davido
Update protobuf to 3.7.1 (PR 2)
1397b69 
Closes bazelbuild#7611.

Change-Id: I3bae96836d9a25f48fed96338e7f4bf59a19d42c
davido added a commit to davido/bazel that referenced this issue Mar 9, 2019
@davido
Update protobuf to 3.7.1 (PR 3)
d6e6e77 
Closes bazelbuild#7611.

Change-Id: I95f61293971ce7dcf4557bf7cf2c8890544c7d31
davido added a commit to davido/bazel that referenced this issue Mar 9, 2019
@davido
Update protobuf to 3.7.1 (PR 4)
498023f 
Closes bazelbuild#7611.

Change-Id: I7557fddc7148d3933c1bf2223bab450f58c5e621
davido added a commit to davido/bazel that referenced this issue Mar 9, 2019
@davido
Update protobuf to 3.7.1 (PR 4)
32b911d 
Closes bazelbuild#7611.

Change-Id: I7557fddc7148d3933c1bf2223bab450f58c5e621
@laszlocsomor laszlocsomor self-assigned this Mar 20, 2019
@laszlocsomor
Copy link
Contributor

/cc @fweikert @philwo @ishikhman

laszlocsomor pushed a commit to laszlocsomor/bazel that referenced this issue Mar 20, 2019
@davido @laszlocsomor
Update protobuf to 3.7.1 (PR 1)
23c7bd8 
On behalf of @davido, merging his PR 1:
bazelbuild@026afdb

This PR must be merged directly to
https://bazel.googlesource.com/bazel/+/master.

Rationale: https://github.com/bazelbuild/bazel/tree/master/third_party/protobuf#1st-pr-add-the-new-protobuf-version-to-the-bazel-tree

See bazelbuild#7611

Change-Id: Ib6edee142ed3cf92806f2b63d119ae11ebe51a6f
@laszlocsomor laszlocsomor mentioned this issue Mar 20, 2019
Closed
@buchgr
Copy link
Contributor

buchgr commented Mar 20, 2019

Hi @davido,

I'd like to understand why you think we need to upgrade the protobuf version in Bazel?

Thanks,
Jakob

@davido
Copy link
Contributor Author

davido commented Mar 20, 2019 •
edited
Loading

@buchgr I already answered this question in my answer to @laszlocsomor in this PR: #7681 (comment) and here: #7775 (comment).

@philwo philwo added P2 We'll consider working on this in future. (Assignee optional) type: feature request and removed untriaged labels May 6, 2019
@meisterT
Copy link
Member

Update to a more recent version in 5e571d2

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@davido @meisterT @philwo @buchgr @aiuto @laszlocsomor