Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package provided in Chocolatey does not declare a dependency #7376

Closed
vmax opened this issue Feb 7, 2019 · 4 comments
Closed

Package provided in Chocolatey does not declare a dependency #7376

vmax opened this issue Feb 7, 2019 · 4 comments
Assignees
Labels
area-Windows Windows-specific issues and feature requests P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@vmax
Copy link
Contributor

vmax commented Feb 7, 2019

Description of the problem / feature request:

bazel installed via Chocolatey does not declare dependency on VC Redist

Feature requests: what underlying problem are you trying to solve with this feature?

I'm trying to use bazel to build code on Windows instance on GCE (specifically windows-2019/windows-cloud)

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

choco install bazel
bazel version => {
cmd -> prints out empty string
bash on msys2 -> prints out C:/ProgramData/chocolatey/bin/bazel.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory
}

What operating system are you running Bazel on?

Windows Server 2019

What's the output of bazel info release?

$ bazel version                                                                                                                                           
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".                            
INFO: Invocation ID: aa5a2fea-ff69-4f76-b963-f7fb4f427831                                                                                                 
Build label: 0.22.0                                                                                                                                       
Build target: bazel-out/x64_windows-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar                                      
Build time: Mon Jan 28 12:59:27 2019 (1548680367)                                                                                                         
Build timestamp: 1548680367                                                                                                                               
Build timestamp as int: 1548680367 

Have you found anything relevant by searching the web?

Related: #5254

Any other information, logs, or outputs that you want to share?

choco install -y vcredist2015 should be ran to be able to use bazel
it should be either automatically installed or at least advised

@dslomov dslomov added area-Windows Windows-specific issues and feature requests untriaged labels Feb 11, 2019
@laszlocsomor
Copy link
Contributor

@petemounce -- could you please take a look?

@laszlocsomor laszlocsomor added type: bug P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Feb 11, 2019
@laszlocsomor laszlocsomor self-assigned this Feb 11, 2019
@RNabel
Copy link
Contributor

RNabel commented Feb 13, 2019

FYI, @petemounce is currently on holiday, will be back in ~2 weeks, so I don't expect this to be addressed until late Feb/early March.

@laszlocsomor
Copy link
Contributor

@RNabel , thanks for the heads-up!

@vmax , is this issue blocking you? Can you work around it until the package is updated?

@vmax
Copy link
Contributor Author

vmax commented Feb 14, 2019

@RNabel @laszlocsomor thank you!

Can you work around it until the package is updated?

Yes, using the hint I posted in Any other information, logs, or outputs that you want to share? in issue description

petemounce pushed a commit to petemounce/bazel that referenced this issue Feb 15, 2019
Fixes bazelbuild#7376. Currently untested, am on holiday without my build environment.

To verify:
1. check out this branch on a Windows computer
1. `cd scripts/packages/chocolatey`
1. in powershell: `./build.ps1 -version 0.23.0 -mode rc -rc 2` (I think 0.23 release is in flight, and rc2 has not been pushed)
  * should produce ./bazel-0.23.0rc2.nupkg (from memory; filename might vary)
1. `choco install --verbose --yes ./bazel-0.23.0rc2.nupkg`
  * should see `[INFO ] - [NuGet] Attempting to resolve dependency 'vcredist2015 (= 14.0.24215.20170201).' in log, where, previous to this change, would not be present in log.
petemounce pushed a commit to petemounce/bazel that referenced this issue May 8, 2019
Fixes bazelbuild#7376. Currently untested, am on holiday without my build environment.

To verify:
1. check out this branch on a Windows computer
1. `cd scripts/packages/chocolatey`
1. in powershell: `./build.ps1 -version 0.23.0 -mode rc -rc 2` (I think 0.23 release is in flight, and rc2 has not been pushed)
  * should produce ./bazel-0.23.0rc2.nupkg (from memory; filename might vary)
1. `choco install --verbose --yes ./bazel-0.23.0rc2.nupkg`
  * should see `[INFO ] - [NuGet] Attempting to resolve dependency 'vcredist2015 (= 14.0.24215.20170201).' in log, where, previous to this change, would not be present in log.
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
Fixes bazelbuild#7376. Currently untested, am on holiday without my build environment.

cc @laszlocsomor, @RNabel, @vmax.

To verify:
1. check out this branch on a Windows computer
1. `cd scripts/packages/chocolatey`
1. in powershell: `./build.ps1 -version 0.23.0 -mode rc -rc 2` (I think 0.23 release is in flight, and rc2 has not been pushed)
    * should produce `./bazel-0.23.0rc2.nupkg` (from memory; filename might vary)
1. `choco install --verbose --yes ./bazel-0.23.0rc2.nupkg`
    * should see `[INFO ] - [NuGet] Attempting to resolve dependency 'vcredist2015 (= 14.0.24215.20170201).' in log, where, previous to this change, would not be present in log.

![selfie-0](https://i.imgur.com/OZHeyFD.png)
[_GitHub Selfies_](https://github.com/thieman/github-selfies/)

Closes bazelbuild#7437.

PiperOrigin-RevId: 257362183
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windows Windows-specific issues and feature requests P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants