Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

February release #2472

Closed
meteorcloudy opened this issue Feb 2, 2017 · 37 comments
Closed

February release #2472

meteorcloudy opened this issue Feb 2, 2017 · 37 comments
Assignees
@hermione521
Labels
P1 I'll work on this now. (Assignee required) type: process
Milestone
0.5

Comments

@meteorcloudy
Copy link
Member

@hermione521 will be our next release manager, hopefully this time it can be 0.5!
@meteorcloudy meteorcloudy added category: misc > release / binary P1 I'll work on this now. (Assignee required) type: process labels Feb 2, 2017
@meteorcloudy meteorcloudy mentioned this issue Feb 2, 2017
Closed
@damienmg damienmg added this to the 0.5 milestone Feb 2, 2017
@damienmg damienmg changed the title Feburary release February release Feb 2, 2017
@damienmg
Copy link
Contributor

As discussed in #2585, we should add a RELNOTES that points to #2585 about the regression on Java type inference.

@petemounce
Copy link
Contributor

That ticket mentions a 0.4.5rc1 - please could I be pinged for RCs and releases (though I'm less likely to miss the latter) by automation? Or, perhaps if the announcements could go a to group where those are the only things that arrive there, in addition to the other lists it hits?

@damienmg
Copy link
Contributor

[email protected] is the mail we are sending those announcement, would you need more?

Sorry for missing pinging you, the rc1 is at https://storage.googleapis.com/bazel/0.4.5/rc1/index.html

@petemounce
Copy link
Contributor

That group is pretty high-traffic, so I don't monitor it closely. Is it possible to get a different group just for RCs/releases? Or to be included in the set of emails that the release script pings?

@petemounce
Copy link
Contributor

The rc is published at https://chocolatey.org/packages/bazel/0.4.5-rc1

@damienmg
Copy link
Contributor

Change we need to make sure are in the release:
88b20ae
a28b540

bazel-io pushed a commit that referenced this issue Feb 28, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
6d1d424 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
hermione521 pushed a commit that referenced this issue Feb 28, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
56a628a 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
@hermione521
Copy link
Contributor

Pushed 0.4.5-rc2, cherry-picked:
a28b540
6d1d424

This change is already in:
88b20ae

@petemounce
Copy link
Contributor

petemounce commented Feb 28, 2017 •
edited
Loading

Published 2nd RC to chocolatey; https://chocolatey.org/packages/bazel/0.4.5-rc2.

@damienmg
Copy link
Contributor

damienmg commented Feb 28, 2017 via email

@damienmg
Copy link
Contributor

damienmg commented Mar 2, 2017

More cherry-picks: 3049051 and more to come.

@meteorcloudy
Copy link
Member Author

Added #2613 as a release blocker, because TensorFlow is failing with Bazel at HEAD due to this bug.
@laszlocsomor already has a fix here: https://bazel-review.googlesource.com/#/c/9126/

hermione521 pushed a commit that referenced this issue Mar 3, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
e0a9701 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
@hermione521
Copy link
Contributor

3049051
is cherry-picked

@damienmg
Copy link
Contributor

damienmg commented Mar 3, 2017

0785cbb also needs cherry-pick. I have 2 in flight change to be cherry-picked and laszlo has one, maybe wait until those next change are pushed to emit a new canary?

@damienmg
Copy link
Contributor

damienmg commented Mar 6, 2017

So more cherry-picks: 934c1d5 7b295d3 0768f3e

Unfortunately there is another regression that came in... So we will need more cherry-picks

hermione521 pushed a commit that referenced this issue Mar 6, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
fbad5f0 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
bazel-io pushed a commit that referenced this issue Mar 6, 2017
@damienmg @vladmos
Flag to import external repositories in python import path
ed77952 
This flag will be used to turn off the feature until we
get support for --incompatible flag.

This flag is going to go away very fast, do not rely on it too much.

To be cherry-picked for 0.4.5 (#2472)

--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
@damienmg
Copy link
Contributor

damienmg commented Mar 6, 2017

So even more cherry-picks: fbad5f0 ed77952

@hermione521
Copy link
Contributor

The first 4 commits are cherry-picked. The other 2 commits will be in the next round.

@damienmg
Copy link
Contributor

damienmg commented Mar 7, 2017

So more cherry-picks yay!

For #2642: 81ae08b
For #2621: cl/149316508 and cl/149369076 when they hit the git repo

hermione521 pushed a commit that referenced this issue Mar 8, 2017
@damienmg @hermione521
Flag to import external repositories in python import path
51f85fd 
This flag will be used to turn off the feature until we
get support for --incompatible flag.

This flag is going to go away very fast, do not rely on it too much.

To be cherry-picked for 0.4.5 (#2472)

--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
hermione521 pushed a commit that referenced this issue Mar 8, 2017
@damienmg @hermione521
Correctly returns null if an environment variables is missing
7ef5856 
The hard part is to test this one as we haven't even
been able to reproduce. Maybe we should just fuzz Skyframe function
for null values.

Fixes #2621.

To cherry-pick for 0.4.5 (#2472)

--
Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3
Reviewed-on: https://cr.bazel.build/9213
PiperOrigin-RevId: 149316508
MOS_MIGRATED_REVID=149316508
@hermione521
Copy link
Contributor

All commits above are cherry-picked.
We reach rc5 with 12 cherry-picks :)

@petemounce
Copy link
Contributor

Please note #2653; not a regression, but an installation failure that's quite painful.

@meteorcloudy
Copy link
Member Author

Please cherry-pick #2599 after it's submitted. It's needed by TensorFlow to build JNI library on Windows.

@meteorcloudy
Copy link
Member Author

92ecbae is the commit from #2599 , please cherry-pick it.

hermione521 pushed a commit that referenced this issue Mar 8, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
767f2bd 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
hermione521 pushed a commit that referenced this issue Mar 8, 2017
@damienmg @hermione521
Flag to import external repositories in python import path
745ebd5 
This flag will be used to turn off the feature until we
get support for --incompatible flag.

This flag is going to go away very fast, do not rely on it too much.

To be cherry-picked for 0.4.5 (#2472)

--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
hermione521 pushed a commit that referenced this issue Mar 8, 2017
@damienmg @hermione521
Correctly returns null if an environment variables is missing
9871879 
The hard part is to test this one as we haven't even
been able to reproduce. Maybe we should just fuzz Skyframe function
for null values.

Fixes #2621.

To cherry-pick for 0.4.5 (#2472)

--
Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3
Reviewed-on: https://cr.bazel.build/9213
PiperOrigin-RevId: 149316508
MOS_MIGRATED_REVID=149316508
@petemounce
Copy link
Contributor

petemounce commented Mar 9, 2017 •
edited
Loading

I've pushed RCs 4-6 inclusive.

What is the status of needing the msys2 dependency? If it's no longer necessary, I can remove both it and the code for mentioning it to users during the package install.

@ulfjack
Copy link
Contributor

ulfjack commented Mar 9, 2017

I think the non-msys2 binary isn't ready yet.

@damienmg
Copy link
Contributor

damienmg commented Mar 9, 2017

MSYS2 dependency should be dropped for 0.5 (still estimate, we technically have reached the 0.5 milestone already).

@kchodorow
Copy link
Contributor

We haven't reached 0.5, which must include #1262.

@damienmg
Copy link
Contributor

damienmg commented Mar 9, 2017 via email

@petemounce
Copy link
Contributor

Would it be possible to get the cherry-picks section of the release notes to render like a list, like the incompatible changes, new features, and important changes sections?

When there are many cherry-picks, it's quite hard to read.

@iirina
Copy link
Contributor

iirina commented Mar 14, 2017

Please also cherry-pick 3695880, thanks!

@damienmg
Copy link
Contributor

And also 8c00f39 b6ea0d3

hermione521 pushed a commit that referenced this issue Mar 14, 2017
@katre @hermione521
Fix paths of binaries in .deb packages.
2d0db9e 
To be cherry-picked for #2472.

Fixes #2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
hermione521 pushed a commit that referenced this issue Mar 14, 2017
@damienmg @hermione521
Flag to import external repositories in python import path
18d2bb3 
This flag will be used to turn off the feature until we
get support for --incompatible flag.

This flag is going to go away very fast, do not rely on it too much.

To be cherry-picked for 0.4.5 (#2472)

--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
hermione521 pushed a commit that referenced this issue Mar 14, 2017
@damienmg @hermione521
Correctly returns null if an environment variables is missing
c8a7eaf 
The hard part is to test this one as we haven't even
been able to reproduce. Maybe we should just fuzz Skyframe function
for null values.

Fixes #2621.

To cherry-pick for 0.4.5 (#2472)

--
Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3
Reviewed-on: https://cr.bazel.build/9213
PiperOrigin-RevId: 149316508
MOS_MIGRATED_REVID=149316508
@petemounce
Copy link
Contributor

Pushed rc7: https://chocolatey.org/packages/bazel/0.4.5-rc7

@renning22
Copy link

Link for non-windows users: https://storage.googleapis.com/bazel/0.4.5/rc7/index.html

@damienmg
Copy link
Contributor

damienmg commented Mar 16, 2017 via email

@damienmg
Copy link
Contributor

https://github.com/bazelbuild/bazel/releases/tag/0.4.5 <-- release \o/

@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.4.5 Pushed, in the queue. Thanks for the heads up :)

@hermione521
Copy link
Contributor

Finally have a release! Closing this.

femik pushed a commit to femik/bazel that referenced this issue Nov 26, 2017
@katre @femik
Fix paths of binaries in .deb packages.
91758ac 
To be cherry-picked for bazelbuild#2472.

Fixes bazelbuild#2605.

--
Change-Id: Idfd1bf264ceb696ca766268c8a16891476ee33b1
Reviewed-on: https://cr.bazel.build/9111
PiperOrigin-RevId: 148749784
MOS_MIGRATED_REVID=148749784
femik pushed a commit to femik/bazel that referenced this issue Nov 26, 2017
@damienmg @femik
Flag to import external repositories in python import path
a478b19 
This flag will be used to turn off the feature until we
get support for --incompatible flag.

This flag is going to go away very fast, do not rely on it too much.

To be cherry-picked for 0.4.5 (bazelbuild#2472)

--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
femik pushed a commit to femik/bazel that referenced this issue Nov 26, 2017
@damienmg @femik
Correctly returns null if an environment variables is missing
7694467 
The hard part is to test this one as we haven't even
been able to reproduce. Maybe we should just fuzz Skyframe function
for null values.

Fixes bazelbuild#2621.

To cherry-pick for 0.4.5 (bazelbuild#2472)

--
Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3
Reviewed-on: https://cr.bazel.build/9213
PiperOrigin-RevId: 149316508
MOS_MIGRATED_REVID=149316508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermione521 hermione521

Labels
P1 I'll work on this now. (Assignee required) type: process
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
8 participants
@kchodorow @petemounce @hermione521 @iirina @damienmg @meteorcloudy @renning22 @ulfjack