Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cc toolchains from tools/cpp to rules_cc #23809

Closed
meteorcloudy opened this issue Sep 30, 2024 · 0 comments
Closed

Move cc toolchains from tools/cpp to rules_cc #23809

meteorcloudy opened this issue Sep 30, 2024 · 0 comments
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Rules-CPP Issues for C++ rules type: feature request

Comments

@meteorcloudy
Copy link
Member

Motivation

Background: #18373 and 975866a

Description

All code for cc toolchains configuration will be moved to rules_cc

Incompatible Flag

N/A

Migration Guide

If you are depending on anything in @bazel_tools//tools/cpp, you should use the version from @rules_cc instead.

In which Bazel LTS version will this incompatible change be enabled?

Bazel 8

Additional Context

No response

TODO List

No response

@meteorcloudy meteorcloudy added type: feature request P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules incompatible-change Incompatible/breaking change team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Sep 30, 2024
copybara-service bot pushed a commit to bazelbuild/rules_cc that referenced this issue Oct 3, 2024
- @bazel_tools//tools/cpp:toolchain_type is not moved.
- Added cc/toolchains/toolchain_config_utils.bzl for exposing util functions for cc toolchain configuration.

Closes #247

Working towards bazelbuild/bazel#23809

PiperOrigin-RevId: 681913803
Change-Id: I16ff456a212ab0e579c137bd74344255f4e49bd8
malt3 added a commit to tweag/rules_nixpkgs that referenced this issue Nov 29, 2024
`nixpkgs_cc_configure_deprecated` depended on Bazel's
cc_autoconf_impl, which was removed from @bazel_tools
and moved into a private package in rules_cc in Bazel 8.

See also: bazelbuild/bazel#23809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants