Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3.0] Path map executable paths #23040

Closed
bazel-io opened this issue Jul 18, 2024 · 2 comments
Closed

[7.3.0] Path map executable paths #23040

bazel-io opened this issue Jul 18, 2024 · 2 comments
Milestone
7.3.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22844
@bazel-io bazel-io added this to the 7.3.0 release blockers milestone Jul 18, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/actions/CommandLines.java
src/main/java/com/google/devtools/build/lib/vfs/PathFragment.java

cc: @bazelbuild/triage

fmeum added a commit to fmeum/bazel that referenced this issue Jul 26, 2024
@fmeum
[7.3.0] Path map executable paths
b0d7f54 
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`.

Work towards bazelbuild#6526
Work towards bazelbuild#22366

Closes bazelbuild#22844.

PiperOrigin-RevId: 656258007
Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37

Closes bazelbuild#23040
@fmeum fmeum mentioned this issue Jul 26, 2024
Merged
fmeum added a commit to fmeum/bazel that referenced this issue Jul 26, 2024
@fmeum
[7.3.0] Path map executable paths
4515833 
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`.

Work towards bazelbuild#6526
Work towards bazelbuild#22366

Closes bazelbuild#22844.

PiperOrigin-RevId: 656258007
Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37

Closes bazelbuild#23040
@iancha1992
Copy link
Member

Cherry-picked in #23118 by @fmeum

github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@fmeum
[7.3.0] Path map executable paths (#23118)
282ac62 
In `CommandLines`, the very first argument of the first command line is
always a path to an executable. As such, it should be path mapped, even
when it is a string. This wasn't the case for `SpawnAction`'s created
via `ctx.actions.run(executable = <some string>)`.

Work towards #6526
Work towards #22366

Closes #22844.

PiperOrigin-RevId: 656258007
Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37

Closes #23040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @bazel-io @iancha1992