Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Add implementation deps support for Objective-C #18298

Closed
bazel-io opened this issue May 3, 2023 · 2 comments
Closed

[6.3.0] Add implementation deps support for Objective-C #18298

bazel-io opened this issue May 3, 2023 · 2 comments
Milestone
6.3.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented May 3, 2023

Forked from #17962
@bazel-io bazel-io added this to the 6.2.0 release blockers milestone May 3, 2023
@keertk keertk changed the title [6.2.0] Add implementation deps support for Objective-C [6.3.0] Add implementation deps support for Objective-C May 3, 2023
@ivan-golub ivan-golub mentioned this issue May 11, 2023
Merged
@keertk
Copy link
Member

keertk commented May 15, 2023

Cherry-picked in #18372

@keertk keertk closed this as completed May 16, 2023
@iancha1992
Copy link
Member

#18372 was merged. Closing this.

@xinzhengzhang xinzhengzhang mentioned this issue Jul 15, 2023
Open
@xinzhengzhang xinzhengzhang mentioned this issue Nov 2, 2023
Merged
brentleyjones pushed a commit to bazelbuild/rules_apple that referenced this issue Nov 2, 2023
@xinzhengzhang
Fix/support implementation deps in objc library (#2317)
b111be2 
Bazel 6.3 supported implementation_deps in objc_library
bazelbuild/bazel#18298 and it seems that we
left out
bazelbuild/rules_swift#1081 (comment)
in fix missing resource collect in private_deps
#2118

I just added implementation_deps in resource collect and test for these
two cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0 release blockers
Development

No branches or pull requests
3 participants
@bazel-io @keertk @iancha1992