Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote_coverage_tools / coverage_output_generator-v2.6.zip lacks provenance, instructions to build from source #15459

Closed
ghost opened this issue May 10, 2022 · 5 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: bug

Comments

@ghost
Copy link

ghost commented May 10, 2022

Description of the bug:

Inside each of the java_tools distribution artifacts is a README.md including instructions to rebuild the artifacts from source.

Example from https://github.com/bazelbuild/java_tools/releases/download/java_v11.7.1/java_tools_linux-v11.7.1.zip

This Java tools version was built from the bazel repository at commit hash 190533739ce4457cd5a3b31573fc2ae66f92d53e
using bazel version 5.1.1 on platform linux.
To build from source the same zip run the commands:

$ git clone https://github.com/bazelbuild/bazel.git
$ git checkout 190533739ce4457cd5a3b31573fc2ae66f92d53e
$ bazel build //src:java_tools_prebuilt.zip

However remote_coverage_tools / coverage_output_generator-v2.6.zip lacks comparable information. As a result, end users have no idea where these bits came from or how to patch and compile this artifact from source.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

$ wget https://mirror.bazel.build/bazel_coverage_output_generator/releases/coverage_output_generator-v2.6.zip
$ unzip coverage_output_generator-v2.6.zip
$ ls
all_lcov_merger_tools_deploy.jar  
BUILD  
coverage_output_generator-v2.6.zip  
WORKSPACE

Observe that there is no README. Additionally there are no breadcrumbs in the included all_lcov_merger_tools_deploy.jar. (I see no hints of build stamping.)

Which operating system are you running Bazel on?

Linux (CentOS 8)

What is the output of bazel info release?

release 5.1.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels May 18, 2022
@comius
Copy link
Contributor

comius commented May 18, 2022

cc @c-mita

@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 23, 2023
@ghost
Copy link
Author

ghost commented Jul 24, 2023

It will be closed in the next 90 days unless any other activity occurs

This is still valid today.

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Jul 25, 2023
@ulfjack
Copy link
Contributor

ulfjack commented Oct 22, 2023

@hauserx
Copy link
Contributor

hauserx commented Feb 9, 2024

Just for reference, seems the build instructions are here, and looks like building it is a manual process:

https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/bazel/rules/BUILD

# To generate an updated version of CoverageOutputGenerator:
# 1. bazel build tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:coverage_output_generator_zip
# 2. Copy and rename the zip file with a new version locally.
# 3. Upload the file under https://mirror.bazel.build/bazel_coverage_output_generator/releases.
# 4. Update //workspace_deps.bzl and //tools/test/extensions.bzl to point to the new release.

c-mita added a commit to c-mita/bazel that referenced this issue Dec 4, 2024
Includes a README.md file to the final .zip file providing the commit
hash, timestamp, and build command to produce the file.

Fixes bazelbuild#15459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants