Skip to content

Commit

Permalink
syntax: Delete callbackEnabled
Browse files Browse the repository at this point in the history
It appears to be unused.

PiperOrigin-RevId: 326455409
  • Loading branch information
laurentlb authored and copybara-github committed Aug 13, 2020
1 parent 0ac4331 commit c59b833
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ Descriptor stringAttribute(
// withdrawn).
@ParamType(type = StarlarkFunction.class)
},
callbackEnabled = true,
noneable = true,
defaultValue = "None",
named = true,
Expand Down Expand Up @@ -448,7 +447,6 @@ Descriptor intListAttribute(
@ParamType(type = Sequence.class, generic1 = Label.class),
@ParamType(type = StarlarkFunction.class)
},
callbackEnabled = true,
defaultValue = "[]",
named = true,
positional = false,
Expand Down Expand Up @@ -553,7 +551,6 @@ Descriptor labelListAttribute(
@ParamType(type = Dict.class),
@ParamType(type = StarlarkFunction.class)
},
callbackEnabled = true,
defaultValue = "{}",
named = true,
positional = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ public interface StarlarkRuleFunctionsApi<FileApiT extends FileApi> {
@ParamType(type = StarlarkFunction.class) // a function defined in Starlark
},
named = true,
callbackEnabled = true,
noneable = true,
defaultValue = "None",
valueWhenDisabled = "None",
Expand Down
10 changes: 0 additions & 10 deletions src/main/java/net/starlark/java/annot/Param.java
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,6 @@
*/
Class<?> generic1() default Object.class;

/**
* Whether the name of a callback function can be given instead of a computed value. If a callback
* function is used then the value of this parameter will be computed only when actually
* requested. E.g., if a parameter {@code foo} of a function {@code bar} is passed a callback
* function, then only when the method {@code bar} actually asks for the value {@code foo},
* replacing it by a {@link com.google.devtools.build.lib.syntax.StarlarkCallbackFunction} in
* between.
*/
boolean callbackEnabled() default false;

/**
* If true, this parameter can be passed the "None" value in addition to whatever types it allows.
* If false, this parameter cannot be passed "None", no matter the types it allows.
Expand Down

0 comments on commit c59b833

Please sign in to comment.