Skip to content

Commit

Permalink
Mark bazel_docker_sandboxing_test as manual.
Browse files Browse the repository at this point in the history
We cannot run it on Bazel CI, because nested Docker via a shared Docker socket is a security risk, but nested Docker via rootless Docker or Podman doesn't work reliably enough yet.

RELNOTES: None.
PiperOrigin-RevId: 295107722
  • Loading branch information
philwo authored and copybara-github committed Feb 14, 2020
1 parent 35a0bfd commit c1e69d0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
4 changes: 0 additions & 4 deletions .bazelci/postsubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ tasks:
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/8162
- "-//src/java_tools/buildjar/..."
- "-//src/java_tools/import_deps_checker/..."
# Bazel CI uses Podman, but it's not available on Ubuntu 16.04.
- "-//src/test/shell/bazel:bazel_docker_sandboxing_test"
include_json_profile:
- build
- test
Expand Down Expand Up @@ -175,8 +173,6 @@ tasks:
- "//tools/python/..."
# C++ coverage is not supported on macOS yet.
- "-//src/test/shell/bazel:bazel_cc_code_coverage_test"
# Docker sandboxing needs Docker installed
- "-//src/test/shell/bazel:bazel_docker_sandboxing_test"
include_json_profile:
- build
- test
Expand Down
4 changes: 0 additions & 4 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ tasks:
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/8162
- "-//src/java_tools/buildjar/..."
- "-//src/java_tools/import_deps_checker/..."
# Bazel CI uses Podman, but it's not available on Ubuntu 16.04.
- "-//src/test/shell/bazel:bazel_docker_sandboxing_test"
ubuntu1804:
shards: 4
shell_commands:
Expand Down Expand Up @@ -170,8 +168,6 @@ tasks:
- "-//src/java_tools/import_deps_checker/..."
# C++ coverage is not supported on macOS yet.
- "-//src/test/shell/bazel:bazel_cc_code_coverage_test"
# Docker sandboxing needs Docker installed
- "-//src/test/shell/bazel:bazel_docker_sandboxing_test"
windows:
shards: 4
batch_commands:
Expand Down
1 change: 1 addition & 0 deletions src/test/shell/bazel/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,7 @@ sh_test(
],
tags = [
"local",
"manual", # TODO(philwo) re-enable once Bazel CI supports Docker again
"no_windows",
],
)
Expand Down

0 comments on commit c1e69d0

Please sign in to comment.