Skip to content

Commit

Permalink
Don't send unnecessary lockfile event
Browse files Browse the repository at this point in the history
`BazelLockFileModule` is the only consumer of `BazelModuleResolutionEvent` and only subscribes with `--lockfile_mode=update`.

Closes #20154.

PiperOrigin-RevId: 581955314
Change-Id: I2ef8a39833c1d195eccdd32fd8e3f86782979dc5
  • Loading branch information
fmeum authored and copybara-github committed Nov 13, 2023
1 parent ba38aa2 commit 560327f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public SkyValue compute(SkyKey skyKey, Environment env)
ImmutableBiMap<String, ModuleExtensionId> extensionUniqueNames =
calculateUniqueNameForUsedExtensionId(extensionUsagesById);

if (!lockfileMode.equals(LockfileMode.OFF)) {
if (lockfileMode.equals(LockfileMode.UPDATE)) {
// This will keep all module extension evaluation results, some of which may be stale due to
// changed usages. They will be removed in BazelLockFileModule.
BazelLockFileValue updateLockfile =
Expand Down

0 comments on commit 560327f

Please sign in to comment.