Skip to content

Commit

Permalink
Restore out-of-process symlink trees
Browse files Browse the repository at this point in the history
These tests became ineffective with the flip of `--experimental_inprocess_symlink_creation`.
  • Loading branch information
fmeum committed Jan 9, 2025
1 parent 293be8a commit 476327e
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/test/shell/bazel/runfiles_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -354,23 +354,27 @@ EOF
function test_runfiles_tree_file_type_changes_tree_to_individual {
setup_runfiles_tree_file_type_changes

bazel build --//pkg:use_tree=True //pkg:output || fail "Build failed"
bazel build --noexperimental_inprocess_symlink_creation \
--//pkg:use_tree=True //pkg:output || fail "Build failed"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample1.txt ]] || fail "sample1.txt not found"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample2.txt ]] || fail "sample2.txt not found"

bazel build --//pkg:use_tree=False //pkg:output || fail "Build failed"
bazel build --noexperimental_inprocess_symlink_creation \
--//pkg:use_tree=False //pkg:output || fail "Build failed"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample1.txt ]] || fail "sample1.txt not found"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample2.txt ]] || fail "sample2.txt not found"
}

function test_runfiles_tree_file_type_changes_individual_to_tree {
setup_runfiles_tree_file_type_changes

bazel build --//pkg:use_tree=False //pkg:output || fail "Build failed"
bazel build --noexperimental_inprocess_symlink_creation \
--//pkg:use_tree=False //pkg:output || fail "Build failed"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample1.txt ]] || fail "sample1.txt not found"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample2.txt ]] || fail "sample2.txt not found"

bazel build --//pkg:use_tree=True //pkg:output || fail "Build failed"
bazel build --noexperimental_inprocess_symlink_creation \
--//pkg:use_tree=True //pkg:output || fail "Build failed"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample1.txt ]] || fail "sample1.txt not found"
[[ -f bazel-bin/pkg/output.runfiles/_main/lib/sample2.txt ]] || fail "sample2.txt not found"
}
Expand Down

0 comments on commit 476327e

Please sign in to comment.