Skip to content

Commit

Permalink
Remove experimental flag from cc_shared_library
Browse files Browse the repository at this point in the history
RELNOTES:cc_shared_library is no longer experimental, see #16709 for details
PiperOrigin-RevId: 516573037
Change-Id: I0c30f9f60e731e9a91035f78ef084a1c5157c011
  • Loading branch information
oquenchil authored and copybara-github committed Mar 14, 2023
1 parent 8be2180 commit 02ad119
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,6 @@ def _get_deps(ctx):
return deps

def _cc_shared_library_impl(ctx):
semantics.check_experimental_cc_shared_library(ctx)

if not cc_common.check_experimental_cc_shared_library():
if len(ctx.attr.static_deps):
fail(
Expand Down
6 changes: 0 additions & 6 deletions src/main/starlark/builtins_bzl/common/cc/semantics.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"""Semantics for Bazel cc rules"""

load(":common/cc/cc_helper.bzl", "cc_helper")
load(":common/cc/cc_common.bzl", "cc_common")

def _get_proto_aspects():
return []
Expand Down Expand Up @@ -152,10 +151,6 @@ def _check_can_use_implementation_deps(ctx):
if (not experimental_cc_implementation_deps and ctx.attr.implementation_deps):
fail("requires --experimental_cc_implementation_deps", attr = "implementation_deps")

def _check_experimental_cc_shared_library(ctx):
if not cc_common.check_experimental_cc_shared_library():
fail("Pass --experimental_cc_shared_library to use cc_shared_library")

def _get_linkstatic_default(ctx):
if ctx.attr._is_test:
# By default Tests do not link statically. Except on Windows.
Expand Down Expand Up @@ -205,7 +200,6 @@ semantics = struct(
get_grep_includes = _get_grep_includes,
get_implementation_deps_allowed_attr = _get_implementation_deps_allowed_attr,
check_can_use_implementation_deps = _check_can_use_implementation_deps,
check_experimental_cc_shared_library = _check_experimental_cc_shared_library,
get_linkstatic_default = _get_linkstatic_default,
get_runtimes_toolchain = _get_runtimes_toolchain,
get_test_malloc_attr = _get_test_malloc_attr,
Expand Down
1 change: 0 additions & 1 deletion src/main/starlark/tests/builtins_bzl/cc_builtin_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ EOF

bazel $START_OPTS test --define=is_bazel=true --test_output=streamed \
--experimental_cc_shared_library_debug \
--experimental_cc_shared_library \
//src/main/starlark/tests/builtins_bzl/cc/... || fail "expected success"
}

Expand Down

0 comments on commit 02ad119

Please sign in to comment.