add [email protected] #3306
Open
add [email protected] #3306
+366
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @protobuf-team-bot, @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR. Please review the changes. |
tongke6
force-pushed
the
tk/protobuf
branch
2 times, most recently
from
4362718
to
d221d3a
Compare
honnix
reviewed
Dec 4, 2024
| module( | ||
| name = "protobuf", | ||
| version = "25.5", | ||
| compatibility_level = 1, |
There was a problem hiding this comment.
Maybe it is better to have repo_name = "com_google_protobuf", because of https://github.com/protocolbuffers/protobuf/blob/9d0ec0f92b5b5fdeeda11f9dcecc1872ff378014/WORKSPACE#L1, and there are references to this name in the repo.
There was a problem hiding this comment.
This was written in imitation of the bzlmod files from other versions of protobuf in the BCR, none of them include the repo_name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.