-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openssl, built with cc_libraries #3304
base: main
Are you sure you want to change the base?
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (openssl) have been updated in this PR. Please review the changes. |
b9e0003
to
ed7e5b7
Compare
@illicitonion Let me know when you consider this ready for review. It looks terrifying, but super useful! |
Why do we need such large generated .bzl files? In future, we are actually thinking about enforcing a size limit for each PR/module. |
I should be able to reduce this down significantly. Basically there are ~50 source files that get generated as part of the platform-specific config, so right now we're generating a per-platform map of files to their contents in starlark files. In practice, only three of these files are actually platform-specific (at least for the . So we could instead generate ~45 overlay files (which would still be about 1MB but spread across 45 files, rather than 4x 1MB files), and just have three dynamically generated files. What are you thinking of in terms of size limits? |
Mostly for two reasons, 1) make sure the PR is still human reviewable, if there are too many checked-in files, there is a bigger risk of getting changes that're not intended by the original author (maybe even security risk). 2) To make the the repo size of BCR doesn't blow up overtime. |
fcf3dcc
to
663d240
Compare
@fmeum ok I think this is good to go now, and a lot less terrifying :) If you're curious, it's generated by https://github.com/raccoons-build/bazel-openssl-cc |
No description provided.