Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssl, built with cc_libraries #3304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illicitonion
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

bazel-io commented Dec 3, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (openssl) have been updated in this PR. Please review the changes.

@alexeagle alexeagle added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 3, 2024
@fmeum
Copy link
Contributor

fmeum commented Dec 3, 2024

@illicitonion Let me know when you consider this ready for review. It looks terrifying, but super useful!

@meteorcloudy
Copy link
Member

Why do we need such large generated .bzl files? In future, we are actually thinking about enforcing a size limit for each PR/module.

@illicitonion
Copy link
Contributor Author

Why do we need such large generated .bzl files? In future, we are actually thinking about enforcing a size limit for each PR/module.

I should be able to reduce this down significantly.

Basically there are ~50 source files that get generated as part of the platform-specific config, so right now we're generating a per-platform map of files to their contents in starlark files.

In practice, only three of these files are actually platform-specific (at least for the . So we could instead generate ~45 overlay files (which would still be about 1MB but spread across 45 files, rather than 4x 1MB files), and just have three dynamically generated files.

What are you thinking of in terms of size limits?

@illicitonion illicitonion marked this pull request as draft December 3, 2024 13:33
@meteorcloudy
Copy link
Member

What are you thinking of in terms of size limits?

Mostly for two reasons, 1) make sure the PR is still human reviewable, if there are too many checked-in files, there is a bigger risk of getting changes that're not intended by the original author (maybe even security risk). 2) To make the the repo size of BCR doesn't blow up overtime.

@illicitonion
Copy link
Contributor Author

@fmeum ok I think this is good to go now, and a lot less terrifying :)

If you're curious, it's generated by https://github.com/raccoons-build/bazel-openssl-cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants