Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rules_req_compile repository location #3300

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sputt
Copy link
Contributor

@sputt sputt commented Dec 2, 2024

No description provided.

@bazel-io
Copy link
Member

bazel-io commented Dec 2, 2024

Hello @abrisco, modules you maintain (rules_req_compile) have been updated in this PR. Please review the changes.

@fmeum fmeum added the USE-WITH-CAUTION-skip-modification-check Allow modifying checked-in modules, reproducible dependency resolution should not be compromised label Dec 2, 2024
Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meteorcloudy Assuming the module is broken as is, this change looks fine to me. What do you think?

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy merged commit 6f70c65 into bazelbuild:main Dec 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
USE-WITH-CAUTION-skip-modification-check Allow modifying checked-in modules, reproducible dependency resolution should not be compromised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants